coala-bears
coala-bears copied to clipboard
Fixed issue #2304: GitCommitBearTest.py : Typo in line 50
For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!
Checklist
- [x] I read the commit guidelines and I've followed them.
- [x] I ran coala over my code locally. (All commits have to pass individually. It is not sufficient to have "fixup commits" on your PR, our bot will still report the issues for the previous commit.) You will likely receive a lot of bot comments and build failures if coala does not pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.
Please consider helping us by reviewing other peoples pull requests as well:
- pick up any PR at https://coala.io/review
- review it (check https://coala.io/reviewing for more info)
- if you are sure that it needs work, use
corobo mark wip <URL>
to get it out of the review queue.
The more you review, the more your score will grow at coala.io and we will review your PRs faster!
Hi @msrijita18 You might want to go through commit guidelines (http://coala.io/commit) once. We have three portions in a commit message, the shortlog, body and issue reference. Your commit is missing the first two Please fix and ammend this PR
Feel free to ask for help if you get stuck
Hi @msrijita18 You might want to go through commit guidelines (http://coala.io/commit) once. We have three portions in a commit message, the shortlog, body and issue reference. Your commit is missing the first two Please fix and ammend this PR
Feel free to ask for help if you get stuck
Is it fine now? Thanks!
Please have a look at https://api.coala.io/en/latest/Developers/Newcomers_Guide.html#step-7-review-process It explains amending commit messages
All commits in your PR have to follow the guidelines (so there should be no merge commits) You'd have to rebase your commits
Is it fine now? I followed this https://api.coala.io/en/latest/Developers/Newcomers_Guide.html#step-7-review-process and this for rebasing https://api.coala.io/en/latest/Developers/Git_Basics.html#rebasing. Thanks!
@msrijita18, please squash all your commits into a single commit
@msrijita18, please squash all your commits into a single commit
I have squashed all the commits into a single commit. Is it fine now? Also should I rebase the commit again? Thanks!
@msrijita18 I don't think that is necessary. @virresh maybe you can merge this now, changes look good to me