coala-bears
coala-bears copied to clipboard
LineCountBear fails for symbolic links
In projects repo
data/locale/en/projects/README.md
**** LineCountBear [Section: linecount | Severity: NORMAL] ****
! ! This file has 0 lines, while 1 lines are required.
[WARNING][03:28:48] LineCountBear: This result has no patch attached.
_projects/README.md
**** LineCountBear [Section: linecount | Severity: NORMAL] ****
! ! This file has 0 lines, while 1 lines are required.
This became a problem because of https://github.com/coala/coala-bears/issues/1477 .
The error is actually truthful as the files do have zero lines, but it is misleading/confusing.
The justification in https://github.com/coala/coala-bears/issues/1477 for a non-zero default is reasonable -- even though it is a change of behaviour from the previous release. While this is a regression, it is a by-product. Rather than change the default, and loose the benefits of it, fixing the handling of symlinks resolves the regression.
Skipping symlinks should be a feature of coala core, not separately built into each bear, so this needs to be upstreamed to coala core.
(There are also other very critical problems with symlinks in coala core, and probably issue already created)
hello, I want to work on this issue but I am new to open source can someone please guide me.