New actions for GitCommitBear

[akshatkarani]

This adds two new actions for GitCommitBear:

1. AddNewlineAction: This adds a newline between shortlog and body of the commit message.
2. EditCommitMessageAction: Open an editor in which user can edit the commit message

This also modifies CommitBear.py to pass these actions when Result is yielded.

Temp changes for travis commit is temporary commit because this PR depends on https://github.com/coala/coala/pull/6029

[akshatkarani]

EditCommitMessageAction and AddNewlineAction in action

[akshatkarani]

Travis is failing because it depends on https://github.com/coala/coala/pull/6029

[abhishalya]

Yeah, please add the coala requirement as your branch.

[abhishalya]

Yeah, please add the coala requirement as your branch.

Btw this is only temporary, to check if the changes work fine.

[akshatkarani]

Yeah, please add the coala requirement as your branch.

I made these changes, am I doing something wrong because the first travis job is failing because of some weird reason but it was passing before.

[abhishalya]

You can ignore the first job of Sentinel since it fails for moban. But, the rest should pass... Looks like a breaking test.

[abhishalya]

Btw, I think the rest of the jobs would stop if Sentinel fails (which it would eventually since the first one would fail due to moban) so instead of restarting those you can also make relevant changes to travis.

[akshatkarani]

Look at the error of the second build. This is because the changes in https://github.com/coala/coala/pull/6029 are not there yet.

[abhishalya]

coala is being installed correctly there from your branch, let me try this out locally

[abhishalya]

@akshatkarani This seems to be the problem...

[akshatkarani]

Removed the first sentinel build, now only one build is failing and the error is the same.

[akshatkarani]

Okay build is passing with these temporary changes.

[abhishalya]

Nice, (since other mentors aren't active) give me some time to check this (and the core changes) in more detail.

[abhishalya]

Ping @Makman2

[Makman2]

1. What about the temp-commit? ;)
2. I would expect in the commit for AddNewlineAction to just do stuff with this action only, not mixing with EditCommitMessageAction. Please properly separate into the commits :+1:

[akshatkarani]

1. What about the temp-commit? ;)

This PR depends on https://github.com/coala/coala/pull/6029, so for builds to pass this commit has been added. Once that PR is merged it can be removed.

2. I would expect in the commit for AddNewlineAction to just do stuff with this action only, not mixing with EditCommitMessageAction. Please properly separate into the commits +1

Yes, I will.

[akshatkarani]

@Makman2 I have separated the commits properly. Also some comments you made on commits have been lost because I amended them, link to it

[abhishalya]

Temp commit not required now, also needs rebase.

[akshatkarani]

Temp commit not required now

This PR still depends on https://github.com/coala/coala/pull/6029 :confused:

[abhishalya]

https://github.com/coala/coala-bears/pull/2855 seems related to moban sync. Also, the commit should be a part of separate PR.

[akshatkarani]

#2855 seems related to moban sync.

Looks pretty old, idk what the rest of changes are for.

Also, the commit should be a part of separate PR.

Okay, https://github.com/coala/coala-bears/pull/2957

[abhishalya]

Don't want to merge this until we have a green build here. coala-bears is already a bit messed up to add more changes. Will keep this back in my head though.