coala-bears icon indicating copy to clipboard operation
coala-bears copied to clipboard

FilenameBear: Move code

Open Makman2 opened this issue 7 years ago • 3 comments

https://github.com/coala/coala-bears/blob/master/bears/general/FilenameBear.py#L74-L75 should be moved to https://github.com/coala/coala-bears/blob/master/bears/general/FilenameBear.py#L49. The condition comes way too late and can be executed earlier^^

This is the relevant code (in case the links do not point to the correct locations any more):

if ignore_uppercase_filenames and filename_without_extension.isupper():
    return

should be moved after this statement:

filename_without_extension, extension = os.path.splitext(tail)

Makman2 avatar Jun 15 '17 23:06 Makman2

I will take this on!

alexkassil avatar Jun 16 '17 05:06 alexkassil

Please go through https://coala.io/newcomer and assign the issue to yourself on our gitter channel via cobot.

yash-nisar avatar Jun 16 '17 07:06 yash-nisar

Looks like @naivedyabansal is not working on this issue anymore. Can I take this up as my first newcomer issue?

pranavmodx avatar Oct 08 '19 11:10 pranavmodx