coala-bears
coala-bears copied to clipboard
coala
Rust Clippy
This is mostly finished now. This integrates rust-clippy with coala, which is the de-facto standard linter for Rust.
I had to work around some stuff. CircleCI uses a rewrite for github clone urls in their default .gitconfig file. As cargo, which is the Rust package manager, doesn't like that, I had to circumvent that. When this issue, which I am tracking, closes, I'll come and remove the workaround. It consists of the git config --global --unset url.ssh://[email protected]:.insteadof option in checkout: post, and the if test in the .ci/deps.sh file. The if test is there to distinguish CircleCI from travis at that point.
On Windows, the clippy linter needs some weird directories in its PATH, because of this Rust bug.
All workarounds are annotated in the source code.
Checklist
- [x] I read the commit guidelines and I've followed them.
- [x] I ran coala over my code locally. (All commits have to pass individually. It is not sufficient to have "fixup commits" on your PR, our bot will still report the issues for the previous commit.) You will likely receive a lot of bot comments and build failures if coala does not pass on every single commit!
TODO
- [x] Use
rustup.rsinstead ofrustup.sh. The former is the successor of the latter. We don't want to have to change that, if we can have it today! :) - [ ] @jayvdb says this is blocked on https://github.com/coala/coala/issues/3867
Comment on 83391bd1f0bef1c993fad143d6699a476083581e.
Shortlog of HEAD commit contains a period at end.
GitCommitBear, severity NORMAL, section commit.
Comment on ce2c3df76f1b14913bb54b714b14b2284834537b.
Shortlog of HEAD commit contains a period at end.
GitCommitBear, severity NORMAL, section commit.
Comment on bd35f4dfc4c388b63c59feb0722c7a04571759d4.
Shortlog of HEAD commit contains a period at end.
GitCommitBear, severity NORMAL, section commit.
Comment on 588e4d2973178d1fe477b5cfbc4431ca75af2032.
Shortlog of HEAD commit contains a period at end.
GitCommitBear, severity NORMAL, section commit.
Comment on 3bd43b316d24d8c8626d11428fb3bf24231792cd.
Shortlog of HEAD commit contains a period at end.
GitCommitBear, severity NORMAL, section commit.
Comment on c6e97fd77161508491d74cb85c5b1be735eab1c1.
Shortlog of HEAD commit isn't in imperative mood! Bad words are 'Debugging'
GitCommitBear, severity NORMAL, section commit.
As soon as the PR is in ready-to-merge state, remove the WIP: in the title @rubdos so it appears in our pending-review list :)
As soon as the PR is in ready-to-merge state, remove the WIP: in the title @rubdos so it appears in our pending-review list :)
Can someone look at the travis-ci/circleci stuff? Appveyor crashes because of the checkstyle.jar bug, but I don't see why travis/circleci crash.
I took away the WIP yesterday, because I wanted someone to review that :/
ah sorry... though for specific issues rather ping us on gitter ;)
The checkstyle bug should have been fixed I believe. Try to rebase to master, if it still fails I'll clean the cache. If it then doesn't work, then we haven't fixed it :3
and about travis: no idea, try to restart the build via the rebase. If it still persists we need to look at it closer^^
The checkstyle bug should have been fixed I believe. Try to rebase to master, if it still fails I'll clean the cache. If it then doesn't work, then we haven't fixed it :3
I am on master... :/
Does clippy have a CLI argument for the filename? If so, that will be easier and more useful than a config dir. (see git grep settings.*_config to get you on the right path).
The get_config_dir problem does look like a bug, either in the core library or in the test framework. Would love to see a bug raised about that, or further discussion on that chat to isolate it a bit more.
Does clippy have a CLI argument for the filename? If so, that will be easier and more useful than a config dir. (see git grep settings.*_config to get you on the right path).
No, clippy is a compiler plugin and compiles the rust project, afaik.
The get_config_dir problem does look like a bug, either in the core library or in the test framework. Would love to see a bug raised about that, or further discussion on that chat to isolate it a bit more.
Ok, I'll make sure to do that.
Err. Is there a CLI argument to specify where to find Cargo.toml. i.e. can we avoid relying on the current working directory.
Is clippy designed to be run on many files together, at once, or one file at a time? If one file at a time, does the order of files process matter?
Err. Is there a CLI argument to specify where to find Cargo.toml. i.e. can we avoid relying on the current working directory.
Oh, that's extremely interesting. Let me check that out. That would solve a lot of troubles :)
Can I let that option default to get_config_dir()?
Is clippy designed to be run on many files together, at once, or one file at a time? If one file at a time, does the order of files process matter?
It is designed as a cargo plugin, so it hook into the build tool. I don't think you can use it on one file at a time, and I also think that certain lints (e.g. "unused code" lints) won't work one file at a time.
Can I let that option default to get_config_dir()?
You know what, I'll just not specify it. I think that's the most logical after all?
Err. Is there a CLI argument to specify where to find Cargo.toml. i.e. can we avoid relying on the current working directory.
@jayvdb Seems like there is one, but bugged :'( I posted an issue on their tracker.
https://github.com/Manishearth/rust-clippy/issues/1611
Found it. People reporting bugs in Russian makes it difficult to Google :/
And here is the English version
Okay, I'm ready for reviews now, I think.
One thing I'd like to ask: how do you guys like these commits? Everything squashed together? I currently have one commit per CI system:
- CircleCI (which also writes the
.ci/deps.shthing, we might want it squashed with Travis, because of.ci/deps.sh) - Travis (which sets the cache and
PATHon Travis) - AppVeyor (which is an atomic commit, downloading and installing Rust on AppVeyor)
Then two other commits:
- Adding the RustClippyLintBear and its test, which works perfectly from the first time on all CI, because it has been set up!
- Add Rust to the README of supported languages.
You guys want everything squashed together? Or in a bunch of steps?
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!
@gitmate-bot is very friendly there, but could someone have a look at #3867 ?
I rebased against master (had some conflicts in the CI files), and I made sure that clippy only outputs severity levels that we know of (I trigger all "kinds" in the test_bad): Allow, Deny, Warning. Only Deny and Warning are reported (as error and warning, respectively)
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!