django-whatever icon indicating copy to clipboard operation
django-whatever copied to clipboard

https://github.com/coagulant/django-whatever/issues/32

Open drtyrsa opened this issue 12 years ago • 2 comments

  1. issues/32 fixed.
  2. Generators are used instead of lists where possible (in xunit.py and models.py only).
  3. '',join(...) is changed to u''.join(...) where possible (in xunit.py and models.py only).
  4. random.randint(0, total - 1) is replaced with random.randrange(total), just clearer and more sematically correct.
  5. Some whitspace is removed where is appropriate.

drtyrsa avatar Jun 02 '12 11:06 drtyrsa

Your changes don't pass the testsuite. python tests/manage.py ... FAILED (failures=11, errors=19)

Test requirements are in /tests/requirements.pip

I'm planning to refactor it and put it on Travis this week.

coagulant avatar Jun 04 '12 15:06 coagulant

Fixed now, all test are passed. BTW, isn't it a good idea to convert all the str things to unicode? Or should they remain byte strings?

drtyrsa avatar Jun 04 '12 16:06 drtyrsa