better-onetab
better-onetab copied to clipboard
cnwangjie
Better OneTab doesn't save changes anymore (using sync, but changes don't save locally either)
扩展版本 (extension version): 1.4.5 浏览器版本 (browser version): Brave Version 0.65.121 Chromium: 75.0.3770.100 (Official Build) (64-bit) 操作系统 (operating system): macOS Mojave - Version 10.14.5 (18F132) 问题描述 (problem description): During a browser session, I will save new tabs, make changes to existing saved tab sets, and reorder pinned tab sets, but none of these changes are maintained in my next browser session. I am using Google to sync, and I am even manually clicking on the sync button from time to time, but it just spins and nothing seems to happen. I have seen this problem for at least the last 2 weeks, but it may have existed before that, because I wasn't actively adding or changing tabs for a while before that.
实际行为 (actual behavior): I can access all my previously saved tabs, and load them effectively, but cannot change anything about those tab sets, and cannot save new tabs.
期望行为 (expected behavior): I should be able to reorder and add/remove tabs and tab sets and have those changes persist locally, as well as being synced to the cloud.
重现步骤 (reproduce step): I don't know how you can reproduce getting into this state, but if you can access my account, hopefully you would see the same behavior. I'm happy to do a screen sharing session to troubleshoot if that would be helpful.
I'm having the same problem here - It seems the lists I saved prior to yesterday are ok, but when I add something to them or create a new one, they don't save.
Been having this for a while, any solutions? @cnwangjie This breaks the extension. It's been like this for more than a month, can it be reverted to a previous version until it's fixed?
This looks to be working again suddenly - Magic?
Nope. Probably simply the extensions auto-update to new versions.
It's not working for me. No changes are saved when I refresh the page. Not currently usable. Love the product but need to go back to Onetab for now.
Hi, I can't reproduce this problem every time. Are all using the sync? I hope to know what environment it'll happen in. Could you provide the result of running the following code in the console panel? Thanks.
chrome.storage.local.get(null, a => console.log(JSON.stringify(a)))
PS. If you are using sync the results may include your credentials and mail. You can delete them before you post them.
@cnwangjie Here's mine with the lists removed:
{"lists":[],"listsUpdatedAt":1563415539870,"opts":{"addHistory":true,"alertRemoveList":true,"allContext":false,"browserAction":"show-list","defaultNightMode":true,"disableDynamicMenu":false,"disableExpansion":false,"disableSearch":false,"disableTransition":false,"excludeIllegalURL":true,"hideFavicon":false,"ignorePinned":false,"itemClickAction":"open-and-remove","itemDisplay":"title-and-url","listsPerPage":15,"openEnd":true,"openTabListNoTab":true,"openTabListWhenNewTab":false,"pageContext":true,"pinNewList":false,"popupItemClickAction":"restore","removeDuplicate":true,"titleFontSize":"18px"},"optsUpdatedAt":1559423136607,"tokenIssued":1564119782587}
and Sync doesn't affect it, I disabled it and same.
I am using sync, via Google. Running Mac OS 10.14.5.
Ran that command in a bash shell and got this output:
-bash: syntax error near unexpected token `null,’
On 26 July 2019 at 07:46:25, Nick Renieris ([email protected]) wrote:
chrome.storage.local.get(null, a => console.log(JSON.stringify(a)))
That's a chrome-API/Javascript command, to be run in Chrome's Javascript console. It's not supposed to be run in the OS terminal console.
Ah that makes more sense, thanks.
Here’s my output, lists and token removed:
"opts":{"addHistory":true,"alertRemoveList":false,"allContext":true,"browserAction":"show-list","defaultNightMode":true,"disableDynamicMenu":false,"disableExpansion":false,"disableSearch":false,"disableTransition":false,"excludeIllegalURL":true,"hideFavicon":false,"ignorePinned":false,"itemClickAction":"open","itemDisplay":"title-and-url","listsPerPage":15,"openEnd":true,"openTabListNoTab":true,"openTabListWhenNewTab":false,"pageContext":true,"pinNewList":false,"popupItemClickAction":"restore","removeDuplicate":false,"titleFontSize":"12px"},"optsUpdatedAt":1564034135201,"token”:"xxxxxx","tokenIssued":1564126123519}
Also, it seems mine started working again too - some updates I made yesterday seem to have stuck today. :nice:
Cheers, -Tommy
On 26 July 2019 at 11:19:45, Igor Pellegrini ([email protected]) wrote:
That's a chrome/Javascript command, to be run in Chrome's Javascript console. It's not to be run in the terminal console.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cnwangjie/better-onetab/issues/206?email_source=notifications&email_token=AAQ25HLCATQKGCCF5L3FE53QBK6TDA5CNFSM4H23SQ62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD24AJIQ#issuecomment-515376290, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ25HLROPQAQOJPZ6WDABDQBK6TDANCNFSM4H23SQ6Q .
Well, the sync worked again for about 2 days, but now it is back to a state where it does not save the edits I make to the lists (editing titles, moving positions, adding/deleting/updating lists).
Cheers, -Tommy
On 26 July 2019 at 13:45:12, Tommy Kiser ([email protected]) wrote:
Ah that makes more sense, thanks.
Here’s my output, lists and token removed:
"opts":{"addHistory":true,"alertRemoveList":false,"allContext":true,"browserAction":"show-list","defaultNightMode":true,"disableDynamicMenu":false,"disableExpansion":false,"disableSearch":false,"disableTransition":false,"excludeIllegalURL":true,"hideFavicon":false,"ignorePinned":false,"itemClickAction":"open","itemDisplay":"title-and-url","listsPerPage":15,"openEnd":true,"openTabListNoTab":true,"openTabListWhenNewTab":false,"pageContext":true,"pinNewList":false,"popupItemClickAction":"restore","removeDuplicate":false,"titleFontSize":"12px"},"optsUpdatedAt":1564034135201,"token”:"xxxxxx","tokenIssued":1564126123519}
Also, it seems mine started working again too - some updates I made yesterday seem to have stuck today. :nice:
Cheers, -Tommy
On 26 July 2019 at 11:19:45, Igor Pellegrini ([email protected]) wrote:
That's a chrome/Javascript command, to be run in Chrome's Javascript console. It's not to be run in the terminal console.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cnwangjie/better-onetab/issues/206?email_source=notifications&email_token=AAQ25HLCATQKGCCF5L3FE53QBK6TDA5CNFSM4H23SQ62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD24AJIQ#issuecomment-515376290, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ25HLROPQAQOJPZ6WDABDQBK6TDANCNFSM4H23SQ6Q .
Without having looked at the code, to me the behaviour seems like something got broken with the emitting/catching of events.
Thank you for your report. I've published a new version. Please reference https://github.com/cnwangjie/better-onetab/issues/121#issuecomment-519410965
If your problem still exists or there is no relation to this problem, please submit a new issue or reopen this issue.
@cnwangjie Well, i'm using this extension today again after a long time. Directly having this issue (mainly) brought me to this page, so it shouldn't be closed. In the meantime, this is really a deal-breaker for the extension, so I hope you could really address it.
Same here, issue is not fixed. I can’t even save new tab sets anymore - the tabs go away, but the UI never updates to show that they saved. And sync does not maintain any changes in ordering or naming of the tab sets beyond the current session.
At this point I have a bunch of old saved tab sets that I still use and can load, but beyond that, the app is really not working at all.
On 19 August 2019 at 23:45:41, MrBitsHub ([email protected]) wrote:
@cnwangjie https://github.com/cnwangjie Well, i'm using this extension today again after a long time. Directly having this issue (mainly) brought me to this page, so it shouldn't be closed. In the meantime, this is really a deal-breaker for the extension, so I hope you could really address it.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cnwangjie/better-onetab/issues/206?email_source=notifications&email_token=AAQ25HIDOMAOWEMIKF46TKTQFMIALA5CNFSM4H23SQ62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4UMRAY#issuecomment-522766467, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ25HK73O5435GOUPC3THTQFMIALANCNFSM4H23SQ6Q .
Maybe adding few unit tests for the minimal functionalities could help?
Or use git bisect in order to find which commit and part of the code introduced the issue.
Or setting a branch with debug logs so that people could try it out and report what's not working.
@Pictor13 Thank you for your suggestion. I already know how the problem is caused. It caused by I set a concurrent lock for storage but it won't be released finally. But through review code, I cannot find out what situation it won't be released. Hope someone could review my code and find out the bug.
I decided to change to use indexedDB instead of extension storage API. It is also asynchronous, but I can rely on its own ACID. So I don't need to manually lock the access data. This may take a while, I need to spend time to debug. But I am busy with work recently.
Any news on this? I am having the same issue, so Better OneTab is unfortunately not usable anymore...
@cnwangjie Please revert back the code to a working version if that's possible. Missing features is way better than broken basic functionality.
I'm stuck with a lot of bookmarks in it, that I would need to manually move somewhere else cause this really is unusable.
Having this issue right now. Newly saved list won't show. I can't remove my existing list either. The lists just won't change no matter what.
问题描述 (problem description): During a browser session, I will save new tabs, make changes to existing saved tab sets, and reorder pinned tab sets, but none of these changes are mai
same
