ecoCode icon indicating copy to clipboard operation
ecoCode copied to clipboard

Fix android sonar cloud bugs

Open med-S opened this issue 3 years ago • 4 comments

med-S avatar Nov 14 '22 13:11 med-S

hello @med-S, please check your failed checks above.

@jhertout, I have the same error in my local environment. Can you review this PR please ? for me it's ok.

dedece35 avatar Nov 18 '22 16:11 dedece35

Hello @dedece35, thanks for the comment. In fact, I had this issue in the main branch and I created this branch to try and fix it I’m working on it to see what I can do

med-S avatar Nov 18 '22 16:11 med-S

@med-S, ok thank you for explanation.

I think we have to define best practices for contribution. For example, to have a fork, then create a branch to make development, and finally, make a PR from branch of personal fork to main of origin repository. The purpose is that mainteners people can review PR before merging in main branch of origin repository. What do you think about it @glalloue, @jules-delecour-dav ?

dedece35 avatar Nov 18 '22 21:11 dedece35

Hi @med-S, we are migrating this repo to a new one : please see https://github.com/green-code-initiative/ecocode-mobile/pull/3 that's why I change this PR to "draft".

dedece35 avatar Nov 28 '22 10:11 dedece35