tmdjs icon indicating copy to clipboard operation
tmdjs copied to clipboard

descriptive-statistics MAX is broken.

Open awb99 opened this issue 1 year ago • 1 comments

(dfn/descriptive-statistics [:min :max :mean :n-values] (map #(+ 2.0 %) (range 1000))) ;; => {:min 2, :max 2, :mean 501.5, :n-values 1000}

(dfn/descriptive-statistics [:min :max :mean :n-values] (range 10)) ;; => {:min 0, :max 0, :mean 4.5, :n-values 10}

awb99 avatar Sep 24 '24 01:09 awb99

its an easy fix I think, in statistics: both min and max use the same mmin-key function.

(defn min
  [v]
  (->> (hamf/apply-nan-strategy nil v)
       (hamf/mmin-key identity)))

(defn max
  [v]
  (->> (hamf/apply-nan-strategy nil v)
       (hamf/mmin-key identity)))

awb99 avatar Sep 24 '24 01:09 awb99