testsuite icon indicating copy to clipboard operation
testsuite copied to clipboard

[Feature] Adding missing ⏭️ for SKIPPED test output on command line and update SKIPPED with :x: emoji

Open agentpoyo opened this issue 3 years ago • 7 comments

Describe the solution you'd like There are SKIPPED tests missing the default ⏭️ emoji or have the :x: during cnf-testsuite output on the command line. All tests that have the SKIPPED option should include this emoji to keep the output consistent.

Additional context These are the current tests missing or have the wrong emoji, ex. :x: instead of ⏭️ from a quick search and find:

src/tasks/workload/installability.cr:  "SKIPPED: Helm Deploy"
src/tasks/workload/configuration_lifecycle.cr:  "✖️  SKIPPED: immutable configmaps..."
src/tasks/platform/observability.cr:  "SKIPPED: Kube State Metrics"
src/tasks/platform/observability.cr:  "SKIPPED: Node Exporter"
src/tasks/platform/observability.cr:  "SKIPPED: Prometheus Adapter"
src/tasks/platform/observability.cr:  "SKIPPED: Metrics Server"
src/tasks/platform/platform.cr:  "SKIPPED: ClusterAPI Enabled"
src/tasks/platform/resilience.cr:  "SKIPPED: Node Failure"

agentpoyo avatar Jul 21 '21 19:07 agentpoyo

@agentpoyo I want to work on this issue.

srisatya12 avatar Jul 23 '21 13:07 srisatya12

@agentpoyo I want to work on this issue.

Hello @SriSatyaT

Welcome to the CNF Test Suite! and thanks for showing interest in contributing. Here is the link to the Contributing Guide.

If you have any questions, please feel free to tag @lixuna @taylor @wavell @denverwilliams @agentpoyo @HashNuke and/or @williscool.

agentpoyo avatar Jul 23 '21 13:07 agentpoyo

@agentpoyo I want to work on this issue.

Hello @SriSatyaT

Welcome to the CNF Test Suite! and thanks for showing interest in contributing. Here is the link to the Contributing Guide.

If you have any questions, please feel free to tag @lixuna @taylor @wavell @denverwilliams @agentpoyo @HashNuke and/or @williscool.

I tried to run the command "curl -s https://raw.githubusercontent.com/cncf/cnf-testsuite/main/curl_install.sh | bash" but there was no respond like any message in prompt I waited till 20 minutes and terminated and got this message. Should I proceed to next step or should I run this again. Command Prompt 14-09-2021 21_21_20

srisatya12 avatar Sep 14 '21 16:09 srisatya12

@agentpoyo I want to work on this issue.

Hello @SriSatyaT Welcome to the CNF Test Suite! and thanks for showing interest in contributing. Here is the link to the Contributing Guide. If you have any questions, please feel free to tag @lixuna @taylor @wavell @denverwilliams @agentpoyo @HashNuke and/or @williscool.

I tried to run the command "curl -s https://raw.githubusercontent.com/cncf/cnf-testsuite/main/curl_install.sh | bash" but there was no respond like any message in prompt I waited till 20 minutes and terminated and got this message. Should I proceed to next step or should I run this again.

Hello @SriSatyaT ,

The cnf-testsuite doesn't run natively on the Windows Command Line. You can setup WSL (Windows Subsystem for Linux) to install the suite onto. But you'll need a bash prompt in order to successfully install the test suite.

Cheers,

-ap

agentpoyo avatar Sep 14 '21 16:09 agentpoyo

@agentpoyo I want to work on this issue

Qarthak avatar Sep 14 '22 08:09 Qarthak

@Qarthak Hello Sarthak. Feel free to contribute by sending a PR.

If you haven’t tried/used the project before checkout the readme and see if that helps you setup the project. Let us know if you get stuck and we can help you get started.

You can ping any one of us mentioned in the previous comments for help.

HashNuke avatar Sep 14 '22 11:09 HashNuke

@Qarthak @HashNuke

Definitely review the code but I think this might of been addressed already during another issue feature where we cleaned up and reorganized the console output. But do feel free to review to see if any proper emoji handlers are missing or need correction. Thanks.

agentpoyo avatar Sep 14 '22 11:09 agentpoyo

@agentpoyo I think after merging #1852 this issue can be closed.

martin-mat avatar Jan 12 '24 09:01 martin-mat

Acceptance Criteria

  • [x] Find or use existing K8s cluster
  • [x] Setup cnf-testsuite using pre-built binary if available with updates or checkout source code and follow source installation
  • [x] Setup CNF using example or sample CNF's
  • [x] When I run the tests:
    • Helm Deploy
    • immutable configmaps
    • Kube State Metrics"
    • Node Exporter"
    • Prometheus Adapter"
    • Metrics Server"
    • ClusterAPI Enabled"
    • Node Failure" I should see the SKIPPED emoji ⏭️ when the test is SKIPPED.

agentpoyo avatar Jan 15 '24 21:01 agentpoyo