testsuite
testsuite copied to clipboard
[Feature] Redesign manifest generation for helm charts
Currently, for generation of manifests from helm charts, we use Helm.generate_manifest_from_templates
function, which creates temp_template.yml
file with all resources.
There are two problems with this:
-
Helm template
creates unneeded information: notes, helm-specific resources. That makes it harder to parse created manifest and requires additional code to handle removal of this info. -
temp_template.yml
is a confusing name for a file with manifests for resources in Kubernetes. Additionally, that file is being created multiple times: incnfs/<release_name>/temp_template.yml
(seems intended and logical), and incnfs/temp_template.yml
, which doesn't make much sense. That seems to be happening due to call ofexport_manifest
ingenerate_config.cr
during setup process.
Proposed solution:
- Create function for gathering manifest from helm deployment based on
helm get manifest
. - Replace
Helm.generate_manifest_from_templates
function, remove or rename of all template-related functionality and code. - Rename of
temp_template.yml
to something reasonable and less confusing (i.e. -generated_manifest.yml
) - Fix
export_manifest
usage (no manifest file should be created incnfs
directory)