testsuite
testsuite copied to clipboard
[BUG] Jaeger installation does not fail if unsuccessful
Describe the bug Jaeger installation method does not fail nor notify my error/warning in case that jaeger deployments are not ready in time.
To Reproduce Run a spec test that is using jaeger, for example
LOGLEVEL=debug crystal spec --warnings none --tag observability_jaeger_pass
and make one of jaeger kinds not finishing (jaeger-collector jaeger-query, jaeger-agent) as listed here https://github.com/cnti-testcatalog/testsuite/blob/main/src/tasks/utils/jaeger.cr#L17
The Jaeger install method passes anyway after timeouts expire. Usage from spec tests also do not handle errors: https://github.com/cnti-testcatalog/testsuite/blob/main/spec/workload/observability_spec.cr#L165 https://github.com/cnti-testcatalog/testsuite/blob/main/spec/workload/observability_spec.cr#L181
Expected behavior The install method issues a warning message similarly as when cluster_tools deployment timeouts during cnf-setup. Spec tests using jaeger fail then.
Additionally, consider better waiting calls than 3 subsequent in serial.
Similar code adaptations done for cluster-tools: https://github.com/cnti-testcatalog/testsuite/pull/1988 https://github.com/cnf-testsuite/cluster_tools/pull/25