testsuite icon indicating copy to clipboard operation
testsuite copied to clipboard

[MAINTENANCE] Update Crystal Version to Latest Stable (currently v1.11.2)

Open agentpoyo opened this issue 2 years ago • 8 comments

Describe the software update The last crystal update to v1.6.0 was back in December of 2022. The latest stable release now at issue creation is v1.9.2.

Describe why update is needed Crystal should be updated to support the latest stable releases to not fall behind release cycles while older versions start to be deprecated on OS updates and releases.

What version is in use now? 1.6.0

What version is the latest version and/or which version you will use for the update? 1.11.2

Additional context We should also update the latest shards modules in use by the cnf-testsuite where applicable.

agentpoyo avatar Aug 14 '23 20:08 agentpoyo

I've submitted a PR to retriable.cr shard repo - https://github.com/Sija/retriable.cr/pull/12.

From what I checked, that seems to be the only shard that requires an update. Once the PR is merged, I'll submit another PR to update the crystal version and the ameba version in the testsuite.

HashNuke avatar Aug 21 '23 10:08 HashNuke

Created the branch maintain/1814 for changes to this ticket. Will send PR after #1822 is resolved because the main branch builds are failing.

HashNuke avatar Aug 31 '23 02:08 HashNuke

Hi @HashNuke and @agentpoyo - what is the status of updating Crystal?

If done, can the related PR for "Bump crystal-ameba/ameba to 1.5.0" be addressed next? Thanks!

lixuna avatar Oct 25 '23 20:10 lixuna

I've submitted a PR to retriable.cr shard repo - Sija/retriable.cr#12.

Looks like they merged the shard that @HashNuke submitted to support later versions. So we can carry forward.

@lixuna

agentpoyo avatar Oct 27 '23 16:10 agentpoyo

@agentpoyo @HashNuke As of today, the Latest release is 1.11.2

Can this maintenance item be prioritized for Q1?

lixuna avatar Jan 30 '24 16:01 lixuna

@agentpoyo @HashNuke As of today, the Latest release is 1.11.2

Can this maintenance item be prioritized for Q1?

Yeah, I think we can work on this. @HashNuke sound good?

agentpoyo avatar Jan 30 '24 17:01 agentpoyo

@agentpoyo @HashNuke Please share the status of this issue. Thank you :)

lixuna avatar Apr 01 '24 16:04 lixuna

@agentpoyo @HashNuke Please share the status of this issue. Thank you :)

I can start the testing of latest crystal and @HashNuke can probably jump in as well.

agentpoyo avatar Apr 01 '24 19:04 agentpoyo