vcglib icon indicating copy to clipboard operation
vcglib copied to clipboard

Issue with import_ply.h

Open whateveri opened this issue 9 months ago • 2 comments

when I add #include <wrap/io_trimesh/import.h> in my code, there are errors with the function LoadCamera in wrap/io_trimesh/import_ply.h saying no member named 'camera' in 'ImporterPLY<OpenMeshType>' and no member named 'pi' in 'ImporterPLY<OpenMeshType>' , like the picture shows. I noticed the function LoadCamera was deleted in io_tetramesh/import_ply.h , it's there something wrong with the head file?

Image

whateveri avatar Mar 06 '25 11:03 whateveri

I encountered the same error with LLVM19, and solved it by switching to LLVM18.

yzx9 avatar Mar 28 '25 07:03 yzx9

Last working gcc version gcc:14.2.1 This is related to gcc:15 no longer allowing qualified identifiers lookup in the current instantiation. https://developers.redhat.com/articles/2025/04/24/new-c-features-gcc-15#additional_updates Also this looks like leftover code that does nothing, and should be removed, like in wrap/io_tetramesh/import_ply.h

bartoszek avatar May 16 '25 14:05 bartoszek

The file /wrap/io_trimesh/import_ply.h of version vcglib-2023.12 has obvious C++ syntax errors in the LoadCamera function (there is a this pointer that tries to address members that do not exist in the class). These are revealed when one tries to compile meshlab under openSUSE Tumbleweed. A patch (that just masks the wrong function through the preprocessor) is in https://build.opensuse.org/projects/home:rjmathar/packages/meshlab/files/vcglib-trimesh.patch?expand=1 Associated PR is https://github.com/cnr-isti-vclab/vcglib/pull/246

rmathar avatar Jul 07 '25 15:07 rmathar