Chris Pryer

Results 206 comments of Chris Pryer

``` > rye publish --repository-url https://test.pypi.org/legacy/ No access token found, generate one at: https://pypi.org/manage/account/token/ Access token: [redacted] Enter a passphrase (optional): Uploading distributions to https://test.pypi.org/legacy/ Uploading rye_publish-0.1.0-py3-none-any.whl 100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.6/3.6...

> fwiw in maturin we use cli args, env vars (e.g. for github actions), system keyring integration (remembers your password after succesful upload), and recently messense implemented OIDC trusted publicher...

I'll mark this as ready to review. Struggling to find time, so maybe I can get some feedback for the next window I have to work on this. It might...

> I will review this today! Thanks! I want to put a little more time into to the url cli argument (eg: `https://test.pypi.org/legacy` will fail with a redirect due to...

I have time today and tomorrow morning to work on any changes here if needed.

For a first-pass would you want to just add `twine` to the bootstrapping and default to a dist/ unless the user indicates another directory/target should be used? I could add...

I should have this in bold. This issue's description is pretty busy. I'll clean it up when I get a chance. The initial *value-prop* for recognizing library vs app internally...

The goal is to discuss 1. Is this a good default to get started with? 2. Should we add a test to the default? 3. Should we also think about...

Yea atm I agree that 2 should be a no. > But it's worth to think about how and when to pin dependencies tightly and how to enable the user...

I've chopped down the issue description to exclude the proposal for including tests. It's really not even on the table as long as `rye` doesn't bundle a testing tool.