koa-limit icon indicating copy to clipboard operation
koa-limit copied to clipboard

too many concerns

Open tj opened this issue 10 years ago • 3 comments

IMO this comes across as a little confusing, it does ip denial and rate-limiting, which we already have, so two in this org might confuse people. Also when mentioned in https://github.com/koajs/ratelimit/issues/5 I thought koa-limit would be request body limiting.

White/black listing is cool but I think we should make it a separate middleware personally. Also in-memory rate limiting isn't very useful since most if not all real API deployments will be multi-process if not multi-machine

something like .use(allow(ips)) and .use(deny(ips)) would be cool

tj avatar May 22 '14 00:05 tj

i think the white listing should within ratelimit, so the ip won't block by rate limit middleware. and this stuff is a little customize for my own app, i'll move it to another org.

dead-horse avatar May 22 '14 01:05 dead-horse

easy to add them above the rate limiting middleware so they take precedence, i dunno, just my $0.2

tj avatar May 22 '14 03:05 tj

yeah we don't need this

i added blacklist/whitelist in https://github.com/koajs/ratelimit/pull/17

niftylettuce avatar Jan 19 '16 20:01 niftylettuce