koa-limit
koa-limit copied to clipboard
too many concerns
IMO this comes across as a little confusing, it does ip denial and rate-limiting, which we already have, so two in this org might confuse people. Also when mentioned in https://github.com/koajs/ratelimit/issues/5 I thought koa-limit would be request body limiting.
White/black listing is cool but I think we should make it a separate middleware personally. Also in-memory rate limiting isn't very useful since most if not all real API deployments will be multi-process if not multi-machine
something like .use(allow(ips))
and .use(deny(ips))
would be cool
i think the white listing should within ratelimit, so the ip won't block by rate limit middleware. and this stuff is a little customize for my own app, i'll move it to another org.
easy to add them above the rate limiting middleware so they take precedence, i dunno, just my $0.2
yeah we don't need this
i added blacklist/whitelist in https://github.com/koajs/ratelimit/pull/17