Johannes Przymusinski comments

Results 22 comments of


                                            Johannes Przymusinski

Storefront: hot-proxy only works with http `sales_channel_domain`s

This should be fixable in the hot-proxy when just tranferring the shema to the request thats made to the backend. I'd like to work on this and provide a PR

Storefront: hot-proxy only works with http `sales_channel_domain`s

Yes, but that would not solve my issue :D My issue is that the hot-proxy tries to access Shopware with `http://` instead of `https://`, ignoring the `https://` in the `APP_URL`...

Storefront: hot-proxy only works with http `sales_channel_domain`s

I've just tried a bit more and got it working somehow with only the 'https://' domain configured. Will play around with that later / tomorrow and update the issue accordingly.

fix: added TS defs

Hi @Demwunz, firstly ... sorry for the late response. Looks good on first sight, will try it out together with the other changes related to cookieconsent v3 and will merge...

fix: added TS defs

Suggestion implemented by #23

Can't configure callbacks

Are you passing the function directly in the Astro config? That's not possible as far as I'm aware, but I haven't tried to be honest. I'll find some time the...

Can't configure callbacks

Sorry for the long silence ... my current idea to solve this, is to load the config from the window object, which you could then define in your main Layout...

return data from Signup() Local Composable

I stumbled across this, trying to catch failing login requests in the `refresh` provider, which is seemingly not possible atm. At least by `await`ing the `signIn` call. When there is...

Load `baseURL` from runtime config

Maybe related to #797

add `nvm alias default` command

I also ran into this, installing node only via `nvm` on a new installed machine, rather than adding `nvm` after installing node.js in a "traditional" way :D Would be awesome...