toc icon indicating copy to clipboard operation
toc copied to clipboard

[SANDBOX PROJECT ONBOARDING] Krustlet

Open amye opened this issue 4 years ago • 46 comments

Welcome to CNCF Project Onboarding! This is an issue created to help onboard your project into the CNCF after the TOC has voted to accept your project. We would like to complete onboarding within one month of acceptance.

From the project side, please ensure that you:

  • [x] Understand the project proposal process and reqs: https://github.com/cncf/toc/blob/main/process/project_proposals.adoc#introduction
  • [x] Understand the services available for your project at CNCF https://www.cncf.io/services-for-projects/
  • [x] Ensure your project meets the CNCF IP Policy: https://github.com/cncf/foundation/blob/master/charter.md#11-ip-policy
  • [x] Review the online programs guidelines: https://github.com/cncf/foundation/blob/master/online-programs-guidelines.md
  • [x] Understand the trademark guidelines: https://www.linuxfoundation.org/en/trademark-usage/
  • [x] Has your project adopted open governance already? see http://opengovernance.dev
  • [x] Slack: Are your slack channels migrated to the Kubernetes or CNCF Slack?
  • [x] Is your project in its own separate neutral github organization?
  • [x] Submitted a Pull request to add your project as a sandbox project to https://landscape.cncf.io

Things that CNCF will need from the project:

  • [x] Owners file: Please add a link to your owners file to this issue, this is used to be able to create your maintainers mailing list.
  • [x] Create maintainer list + added to aggregated https://maintainers.cncf.io list
  • [x] Domain: transfer domain to the CNCF - please send a transfer code to [email protected]
  • [x] Trademarks: transfer any trademark and logo mark assets over to the LF - https://github.com/cncf/foundation/tree/master/agreements has agreements
  • [x] GitHub: ensure 'thelinuxfoundation' and 'caniszczyk' are added as initial org owners, this helps us make sure we have continuity of GH ownership
  • [x] GitHub: ensure DCO or CLA are enabled for all GitHub repositories of the project
  • [x] Artwork: Ensure logos present on https://github.com/cncf/artwork
  • [x] Website: ensure LF footer is there and website guidelines followed
  • [x] Website: Analytics transferred to [email protected]
  • [ ] Adopt a license scanning tool, like FOSSA or Snyk
  • [x] CII: Start on a CII best practices badge https://bestpractices.coreinfrastructure.org/en

Things that the CNCF will do or help the project to do:

  • [x] Devstats: add to devstats https://devstats.cncf.io/
  • [x] Marketing: update relevant intro + slide decks
  • [x] Events: update CFP + Registration + CFP Area forms
  • [x] ServiceDesk: confirm maintainers have read https://www.cncf.io/services-for-projects/
  • [x] CNCF Welcome Email Sent to confirm maintainer list access, welcome email has monthly project sync details
  • [x] Create space for meetings/events on community.cncf.io, e.g., https://community.cncf.io/pravega-community/

amye avatar Jul 13 '21 17:07 amye

This is great news! We'll start working on all the steps shortly

thomastaylor312 avatar Jul 13 '21 17:07 thomastaylor312

@thomastaylor312: One thing that would be a big help is an OWNERS file, I don't see anything in https://github.com/deislabs/krustlet

amye avatar Jul 13 '21 18:07 amye

Yeah, I'll take care of that first

thomastaylor312 avatar Jul 13 '21 20:07 thomastaylor312

Please ping me when this project moves to a separate GitHub org.

lukaszgryglicki avatar Jul 14 '21 10:07 lukaszgryglicki

Devstats instance created.

lukaszgryglicki avatar Jul 15 '21 16:07 lukaszgryglicki

Here is a PR to add a code owners file to the repo - https://github.com/deislabs/krustlet/pull/643

It is using the CODEOWNERS format, as defined by GitHub - https://help.github.com/en/articles/about-code-owners, let us know if the format is ok, or if we need to change it to an OWNERS file.

radu-matei avatar Jul 16 '21 00:07 radu-matei

That’s fine

On Thu, Jul 15, 2021 at 7:06 PM Radu M @.***> wrote:

Here is a PR to add a code owners file to the repo - deislabs/krustlet#643 https://github.com/deislabs/krustlet/pull/643

It is using the CODEOWNERS format, as defined by GitHub - https://help.github.com/en/articles/about-code-owners, let us know if the format is ok, or if we need to change it to an OWNERS file.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/cncf/toc/issues/690#issuecomment-881085178, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIJGJGFM2YIW7MMDF33TX5ZZZANCNFSM5AJTV3GA .

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

caniszczyk avatar Jul 16 '21 00:07 caniszczyk

For the license scanning tool, is there a free for open source version of one of those tools or a license the CNCF can give us access to?

thomastaylor312 avatar Jul 16 '21 16:07 thomastaylor312

we have access to both https://github.com/fossas/fossa-cli and snyk, choose which one you like :D

On Fri, Jul 16, 2021 at 11:59 AM Taylor Thomas @.***> wrote:

For the license scanning tool, is there a free for open source version of one of those tools or a license the CNCF can give us access to?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/cncf/toc/issues/690#issuecomment-881588785, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIMPBHJVH7V6CD46L63TYBQP3ANCNFSM5AJTV3GA .

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

caniszczyk avatar Jul 16 '21 17:07 caniszczyk

I think we'll go ahead and use fossa. I assume it will be easier to set up once we move over to a neutral org (which we have, but are tying up a few loose ends before we do)

thomastaylor312 avatar Jul 16 '21 17:07 thomastaylor312

Just contacted our legal team for signing the logo transfer agreement. If needed, is there someone from the CNCF I should pull in?

thomastaylor312 avatar Jul 20 '21 14:07 thomastaylor312

@thomastaylor312: You can start with me and I'll help route it to the correct place.

amye avatar Jul 20 '21 16:07 amye

@thomastaylor312: checking back in here, artwork is the big next step. Thanks!

amye avatar Jul 21 '21 22:07 amye

Yep, things are in motion on our legal side, the agreements will be sent out soon. Then next week I am planning on moving the repos and setting up all the bots

thomastaylor312 avatar Jul 21 '21 23:07 thomastaylor312

Trademark agreement has been signed, so that can be checked off. I'll add the logos to the artwork repo

thomastaylor312 avatar Jul 22 '21 16:07 thomastaylor312

Ok, I have most of the logos added but I am waiting on opening a PR because we are missing a few variations/types of the logo. Some people are out on vacation, so it won't be until Monday-ish next week

thomastaylor312 avatar Jul 22 '21 17:07 thomastaylor312

Added LF and Chris to the new GH org we'll be moving the repo to

thomastaylor312 avatar Jul 22 '21 17:07 thomastaylor312

The repo has been migrated to its new home: https://github.com/krustlet/krustlet

thomastaylor312 avatar Jul 22 '21 19:07 thomastaylor312

wohoo thank you!

On Thu, Jul 22, 2021 at 2:30 PM Taylor Thomas @.***> wrote:

The repo has been migrated to its new home: https://github.com/krustlet/krustlet

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/cncf/toc/issues/690#issuecomment-885177287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIJNWUDQ7RELCJDQ3UTTZBWWPANCNFSM5AJTV3GA .

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

caniszczyk avatar Jul 22 '21 19:07 caniszczyk

DCO is enabled in the new org

thomastaylor312 avatar Jul 22 '21 19:07 thomastaylor312

At this rate, you'll be done by the end of the week! Marking off GH owners, DCO and neutral GH repo

amye avatar Jul 22 '21 20:07 amye

I think we are ready to enable the synk license scanner whenever that is ready!

thomastaylor312 avatar Jul 28 '21 18:07 thomastaylor312

Quick question here as well: We just finished adding some Rust specific license checks. Everything looks good, but there is one transitive dependency with a BSD-2 Clause license. Are there any problems with that for a CNCF project?

thomastaylor312 avatar Aug 02 '21 19:08 thomastaylor312

No issue for that Taylor, you can see the allowlist here: https://github.com/cncf/foundation/blob/master/allowed-third-party-license-policy.md#approved-licenses-for-allowlist

On Mon, Aug 2, 2021 at 2:11 PM Taylor Thomas @.***> wrote:

Quick question here as well: We just finished adding some Rust specific license checks. Everything looks good, but there is one transitive dependency with a BSD-2 Clause license. Are there any problems with that for a CNCF project?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/cncf/toc/issues/690#issuecomment-891266009, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIPDGSODCKP5BIMROZDT23UXRANCNFSM5AJTV3GA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

caniszczyk avatar Aug 02 '21 19:08 caniszczyk

Ok, there was one more license I missed here. We have a transitive dependency on a crate called webpki-roots that has an MPL-2.0 license. It looks like from the FAQ all we might need is a NOTICE file pointing them to the original source. Is this something to open a service desk ticket for?

thomastaylor312 avatar Aug 04 '21 18:08 thomastaylor312

We most likely will have to ask for a license exception, I haven't found webpki-roots in https://github.com/cncf/foundation/tree/master/license-exceptions

If so, open up an issue here for the license exception and we will bring it up in the next CNCF GB meeting: https://github.com/cncf/foundation/issues

I don't see us having an issue here.

On Wed, Aug 4, 2021 at 1:24 PM Taylor Thomas @.***> wrote:

Ok, there was one more license I missed here. We have a transitive dependency on a crate called webpki-roots that has an MPL-2.0 license. It looks like from the FAQ https://www.mozilla.org/en-US/MPL/2.0/FAQ/ all we might need is a NOTICE file. Is this something to open a service desk ticket for?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/cncf/toc/issues/690#issuecomment-892874955, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIOGKJO7QSUQGIJCBRTT3GAULANCNFSM5AJTV3GA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

caniszczyk avatar Aug 05 '21 16:08 caniszczyk

Done! Thank you!

thomastaylor312 avatar Aug 05 '21 16:08 thomastaylor312

@thomastaylor312: Checking back in here, anything else that can be checked off?

amye avatar Oct 04 '21 17:10 amye

These things are done

  • Website: ensure LF footer is there and website guidelines followed
  • I thought this was done, let me know if it isn't: Website: Analytics transferred to [email protected]
  • Everything under the first section except for adding to the landscape

We are waiting on these:

  • Domain: transfer domain to the CNCF - please send a transfer code to [email protected] We sent the transfer code a while ago and never got confirmation if the domain was transferred
  • Adopt a license scanning tool, like FOSSA or Snyk: We were told to wait and we'd get something for snyk. FWIW, we have a Rust specific license tool that already scans everything. If that counts, we can check it off

thomastaylor312 avatar Oct 04 '21 19:10 thomastaylor312

Marking those off! Re: domain - which domain should I be looking for? You can also use this: https://jira.linuxfoundation.org/plugins/servlet/theme/portal/2/create/63 - put it under CNCF @idvoretskyi to weigh in on license scanning:

amye avatar Oct 04 '21 20:10 amye