toc icon indicating copy to clipboard operation
toc copied to clipboard

[PROJECT ONBOARDING] Keycloak

Open amye opened this issue 2 years ago • 38 comments

Welcome to CNCF Project Onboarding! This is an issue created to help onboard your project into the CNCF after the TOC has voted to accept your project. We would like to complete onboarding within one month of acceptance.

From the project side, please ensure that you:

Things that CNCF will need from the project:

  • [x] Provide emails for the maintainers added to https://maintainers.cncf.io in order to get access to the maintainers mailing list and ServiceDesk - [email protected] is the best email to send those to
  • [x] Trademarks: transfer any trademark and logo mark assets over to the LF - https://github.com/cncf/foundation/tree/master/agreements has agreements
  • [ ] GitHub: ensure 'thelinuxfoundation' and 'caniszczyk' are added as initial org owners, this helps us make sure we have continuity of GH ownership that we will onboard to our GitHub Enterprise instance: https://github.com/enterprises/cncf
  • [x] GitHub: ensure DCO or CLA are enabled for all GitHub repositories of the project
  • [x] GitHub: ensure that that the CNCF Code of Conduct (or your adopted version of it) are explicitly referenced at the project's README on GitHub
  • [x] Website: ensure LF footer is there and website guidelines followed (if your project doesn't have a dedicated website, please adopt those guidelines to the README file of your project on GitHub).
  • [x] Website: Analytics transferred to [email protected]
  • [ ] OpenSSF Best Practices Badge: Start on an OpenSSF Best Practices Badge https://bestpractices.coreinfrastructure.org/en

Things that the CNCF will do or help the project to do:

amye avatar Apr 13 '23 18:04 amye

I just noticed this, so I will add this to DevStats after the KubeCon.

lukaszgryglicki avatar Apr 20 '23 11:04 lukaszgryglicki

On it.

lukaszgryglicki avatar Apr 24 '23 08:04 lukaszgryglicki

DevStats page added. Now adding Keycloak to All CNCF DevStats instance.

lukaszgryglicki avatar Apr 25 '23 05:04 lukaszgryglicki

Also added to All CNCF, examples:

Affiliations task will be finished later.

lukaszgryglicki avatar Apr 26 '23 06:04 lukaszgryglicki

Some affiliations imported, and more affiliations will be continuously enhanced & updated in the future (as with all other CNCF projects).

  • https://keycloak.devstats.cncf.io/d/4/company-statistics-by-repository-group?orgId=1.
  • https://keycloak.devstats.cncf.io/d/74/contributions-chart?orgId=1.
  • https://keycloak.devstats.cncf.io/d/5/companies-table?orgId=1.
  • https://keycloak.devstats.cncf.io/d/56/company-commits-table?orgId=1.
  • https://keycloak.devstats.cncf.io/d/55/company-prs-in-repository-groups-table?orgId=1.
  • https://keycloak.devstats.cncf.io/d/66/developer-activity-counts-by-companies?orgId=1.
  • https://keycloak.devstats.cncf.io/d/21/prs-authors-companies-table?orgId=1. And so on...

I'm considering DevStats part done.

lukaszgryglicki avatar Apr 26 '23 07:04 lukaszgryglicki

We've migrated chat to CNCF Slack (current channels are #keycloak #keycloak-dev and #keycloak-maintainers)

stianst avatar May 22 '23 14:05 stianst

Provided emails for the maintainers to https://maintainers.cncf.io/ (https://github.com/cncf/foundation/pull/559)

stianst avatar May 22 '23 14:05 stianst

@stianst Checking in on this one:

  • Submitted a Pull request to add your project as a sandbox project to https://landscape.cncf.io/

This both puts your project on the landscape and the CNCF projects page, so it's pretty important!

Also - artwork?

amye avatar Jun 07 '23 17:06 amye

@amye Keycloak is already listed on https://landscape.cncf.io/ (Keycloak was accepted as an Incubating project, not Sandbox). PR was sent here https://github.com/cncf/landscape/pull/3143

stianst avatar Jun 12 '23 11:06 stianst

@amye for artwork we have our logos in SVG and PNG formats here https://github.com/cncf/artwork, but not in the sizes/formats/layouts expected by https://github.com/cncf/artwork. There's also some bugs in some of the SVGs that causes them not to render properly. We could probably do with a little help from someone in the CNCF to clean these up.

stianst avatar Jun 12 '23 11:06 stianst

@amye Keycloak does have an open governance written here https://github.com/keycloak/keycloak/blob/main/GOVERNANCE.md, I believe we can check this item as completed.

abstractj avatar Oct 03 '23 19:10 abstractj

@amye Keycloak does have its separate neutral GitHub organization https://github.com/keycloak. Could you please check this item as completed. I don't have the rights to do it.

abstractj avatar Oct 03 '23 19:10 abstractj

@amye we do understand the services available for your project at CNCF. Could you please check this item as completed?

abstractj avatar Oct 03 '23 19:10 abstractj

@amye we do understand the project proposal process. Could you please check this item as completed?

abstractj avatar Oct 03 '23 19:10 abstractj

@amye online programs were already reviewed. I believe we can check this item as completed.

abstractj avatar Oct 03 '23 19:10 abstractj

For signed commits will the Require signed commits option provided by GitHub fill the needs for ensure DCO or CLA are enabled for all GitHub repositories of the project

stianst avatar Oct 20 '23 06:10 stianst

For signed commits will the Require signed commits option provided by GitHub fill the needs for ensure DCO or CLA are enabled for all GitHub repositories of the project

No, as that option only verifies the authenticity of the commits. The DCO ensures that what is actually committed is clean for IP purposes.

krook avatar Oct 20 '23 13:10 krook

We're actively trying to get through this list at the moment, so far we've made some progress. The following tasks are completed from our perspective:

  • Understand the project proposal process and reqs
  • Understand the services available for your project at CNCF
  • Website: ensure LF footer is there and website guidelines followed
  • ServiceDesk: confirm maintainers have read https://www.cncf.io/services-for-projects/
  • CNCF Welcome Email Sent to confirm maintainer list access

We've also sent a PR for artwork here https://github.com/cncf/artwork/pull/439

stianst avatar Oct 24 '23 12:10 stianst

For signed commits will the Require signed commits option provided by GitHub fill the needs for ensure DCO or CLA are enabled for all GitHub repositories of the project

No, as that option only verifies the authenticity of the commits. The DCO ensures that what is actually committed is clean for IP purposes.

Got it thanks, we'll look at DCO or CLA then. Any suggestions which is the best?

stianst avatar Oct 24 '23 13:10 stianst

DCOs require substantially less administration. They're basically automatic. CLAs are not.

jberkus avatar Oct 24 '23 18:10 jberkus

Thanks, having read about this some more I'd say DCOs seem the way to go. One final question here though is previous contributions/commits. Is it acceptable to say DCO are required for new contributions, but not past contributions?

Same problem would apply only differently for CLAs. We would have a hard time to get a CLA with every developer that has contributed to Keycloak in the past.

stianst avatar Oct 25 '23 11:10 stianst

Yeah, that's normal for projects joining the CNCF. You just start taking DCOs for new contributions.

jberkus avatar Oct 25 '23 18:10 jberkus

Hi @stianst ! My name is Crystal Mierly and I will be taking over assisting new sandbox projects with the onboarding process! I have gone ahead and updated the list based on your completed tasks so you are a bit closer to completing onboarding.

Did you successfully adopt DCOs for new contributions? Please let me know if you have any further questions or concerns!

Cmierly avatar Dec 13 '23 22:12 Cmierly

Hi @Cmierly

We're an incubating project, not a sandbox project, and we've been trying to wrap-up the on-boarding this year, but took longer than we hoped. We are hoping that we can wrap this stuff up early 2024.

We have adopted DCOs and enabled the app for all repositories under our GitHub organization. We've also transferred website analytics to [email protected].

stianst avatar Dec 14 '23 13:12 stianst

Apologies for the mistake! I've updated the list again, thank you so much for the update

Cmierly avatar Dec 14 '23 21:12 Cmierly

@amye when you get the chance, could you please add a checkmark to the "Code of Conduct" checkbox? It was completed with https://github.com/keycloak/keycloak?tab=coc-ov-file and https://github.com/keycloak/keycloak/blob/main/README.md.

abstractj avatar Jan 25 '24 19:01 abstractj

@abstractj it looks like that item is now checked off.

krook avatar Jan 29 '24 22:01 krook

Thank you @krook, we will continue the work on the remaining items.

abstractj avatar Jan 31 '24 21:01 abstractj

@abstractj a quick check here. There are a few remaining items, any assistance is required with them?

idvoretskyi avatar May 13 '24 13:05 idvoretskyi

@abstractj a quick check here. There are a few remaining items, any assistance is required with them?

@idvoretskyi thank you for offering your help. Our team is currently reassessing all the licenses involved in the project. Based on this reassessment, we are making adjustments wherever possible. Once we have completed this process, we will be in a better position to request any required license exceptions.

We appreciate your support and will reach out if necessary.

abstractj avatar May 14 '24 16:05 abstractj