tag-security icon indicating copy to clipboard operation
tag-security copied to clipboard

Add Monero to Supply Chain Compromises

Open Rishit-dagli opened this issue 3 years ago • 7 comments

This PR adds Monero to the list of Supply Chain compromises

Closes #822

Rishit-dagli avatar Aug 03 '22 12:08 Rishit-dagli

The tests failed due to the spell check action flagging "getmonero" which should also be now fixed

Rishit-dagli avatar Aug 16 '22 10:08 Rishit-dagli

Awesome - thanks! I think we still need the DCO: https://github.com/cncf/tag-security/pull/967/checks?check_run_id=7855919059

Let me know if you need any help with this!

lumjjb avatar Aug 16 '22 12:08 lumjjb

@lumjjb

Awesome - thanks! I think we still need the DCO: https://github.com/cncf/tag-security/pull/967/checks?check_run_id=7855919059

Let me know if you need any help with this!

Ah yes, missed that. the DCO should now pass as well

Rishit-dagli avatar Aug 16 '22 13:08 Rishit-dagli

@Rishit-dagli just a missing update in the contents page on the compromise type, then should be good to merge!

lumjjb avatar Aug 20 '22 19:08 lumjjb

@Rishit-dagli just a missing update in the contents page on the compromise type, then should be good to merge!

Fixed that now

Rishit-dagli avatar Aug 21 '22 04:08 Rishit-dagli

Closing and re-opening pull request to test this #970

PushkarJ avatar Aug 29 '22 18:08 PushkarJ

@lumjjb this PR for some reason needs your approval / withdrawal of your request for changes in the review. Apart from this looks good to merge for me!

PushkarJ avatar Sep 03 '22 00:09 PushkarJ

Sorry for the wait on this @Rishit-dagli merging now!

PushkarJ avatar Oct 14 '22 15:10 PushkarJ