tag-observability
tag-observability copied to clipboard
cncf
commit Chinese version of white paper.
Here, @ArthurSens . I don't know whether the process of directly create pull request is correct or not. This is the translated content. Could you check it out if you have time? Of course, anyone can.
Thank you and look forward to your reply.
Here, @ArthurSens . I don't know whether the process of directly create pull request is correct or not. This is the translated content. Could you check it out if you have time? Of course, anyone can.
Thank you and look forward to your reply.
@chenmudu I'll be happy to do a proofreading on the Chinese version! Thanks for translating!
Generally look good to me. One problem is that can we keep consistency for the nouns? Something like logs, sometime it uses "日志", sometimes it uses "log". Same situation for "paper".
Yes, we should keep to the same style. This is my oversight and I will fix it in the next commit. Thank you for your advice and patience. ♥
@JohnWu20 @lichunli-amzn Some minor bugs that were not easily detect have been fixed. If you have time, could you review it? Thanks a lot.
That's amazing job!
My worry for now is that we still have review period for English version, so it might change a bit. However this gives amazing value already, so maybe we can merge and iterate? 🤗
Here, @ArthurSens . I don't know whether the process of directly create pull request is correct or not. This is the translated content. Could you check it out if you have time? Of course, anyone can.
Direct PR is great, let's have at least one LGTM from Chinese speaker/reader contributor then we can merge (:
@JohnWu20 @lubingfeng @raptorsun Please review it again, if you have time. Thanks a lot.
Direct PR is great, let's have at least one LGTM from Chinese speaker/reader contributor then we can merge (:
Yeah, thanks. Waiting... 😀
@chenmudu @lubingfeng @JohnWu20 @lichunli-amzn 我的修改建议都提完了。有劳各位再校对一下。 @bwplotka My review is over. Now double-checking with other translators 👀
@chenmudu @lubingfeng @JohnWu20 @lichunli-amzn 我的修改建议都提完了。有劳各位再校对一下。 @bwplotka My review is over. Now double-checking with other translators 👀
🎉 This update fixes everyone's suggestions. Thanks a lot. If there are no other problems, I think we can use LGTM to promote the merger of this pull request. ❤
@chenmudu @lubingfeng @JohnWu20 @lichunli-amzn 我的修改建议都提完了。有劳各位再校对一下。 @bwplotka My review is over. Now double-checking with other translators 👀
🎉 This update fixes everyone's suggestions. Thanks a lot. If there are no other problems, I think we can use LGMT to promote the merger of this pull request. ❤
谢谢老兄这么及时的修改。 最后Merge前把 Clearpath的首字母 C 加上就好了。 👍 LGTM. Just correct the typo on "Clearpath" and then it will be ready to merge.
This is so impressive! Thanks a lot to everyone that worked on the translation ❤️
From my side, I think it is fine to merge (if all translators have already approved). As we modify the original, I'll ping you folks to change the Chinese version too. Does that sound reasonable?
As we modify the original, I'll ping you folks to change the Chinese version too. Does that sound reasonable?
Chinese version should change with the original version, I am happy to do so, please feel free to @chenmudu .
LGTM, I think it's time for us to merge this pr. @ArthurSens There hasn't been any problem feedback for several days.
Maybe take another 👀 on my suggestions. @chenmudu @lichunli-amzn @raptorsun @JohnWu20
Maybe take another 👀 on my suggestions. @chenmudu @lichunli-amzn @raptorsun @JohnWu20
Cool, I'll modify it later. @just1900
@JohnWu20 @lubingfeng @raptorsun @just1900 If there are no other problems, let's use LGTM to facilitate the merge of translation content. Thanks for all reviews. ♥ @ArthurSens Maybe we need to consult whether it is time to merge this PR. Thanks a lot.