landscapeapp icon indicating copy to clipboard operation
landscapeapp copied to clipboard

Incorrect url generation for members in <a> hyperlink

Open Btijmen opened this issue 1 year ago • 3 comments

This issue applies to both the CNCF and LFAI landscapes, and I believe this is the result of url-generation in this upsteam app.

What happens?

The url in the a element for the members header is incorrect. On click the element functions as expected, but when opened in a new tab the link leads to a 404.

This happens in the members page when clicking the category link for silver/gold/platinum (CNCF) or associate/general/premier (LFAI) respectively. For clarity, here's a screen shot of the cncf page with the offending link highlighted in a red box:

Screenshot 2023-04-19 at 14 01 24

The hyperlink element looks like this:

<a data-type="internal" href="/card?category=platinum&amp;grouping=category" style="[abridged for legibility]">Platinum</a>

The href part is wrong, and should redirect to /card-mode rather than card.

This seems like a very simple fix and I'd be happy to fix it myself, but I have absolutely no experience in NodeJS and have been unable to find exactly where in the code this has to be fixed. If someone can either fix this, or direct me to the file that needs to be edited, that'd be much appreciated.

Btijmen avatar Apr 19 '23 12:04 Btijmen

Thank you, great catch!

AndreyKozlov1984 avatar Apr 20 '23 12:04 AndreyKozlov1984

@Btijmen It seems that the issue you raised on April 19, 2023, has been resolved. Since there have been no further comments or activity on the issue, and based on my own testing, I believe the problem has been resolved by the programmers of the company.

I suggest closing this issue as it no longer requires any action. Please review and consider closing the issue. Thank you!

RipulHandoo avatar Jun 01 '23 14:06 RipulHandoo

It has not been resolved. Try opening the 'platinum' link in a new tab on this page: https://landscape.cncf.io/members?category=app-definition-and-development&grouping=category

You will find a 404, because the href url is not generated correctly.

Btijmen avatar Jun 01 '23 19:06 Btijmen