landscapeapp icon indicating copy to clipboard operation
landscapeapp copied to clipboard

GitLab support

Open jmertic opened this issue 4 years ago • 9 comments

Hi!

Not sure if this has been considered, but would it be possible to support Gitlab? I'm starting to see a few repos only over there popup...

jmertic avatar Mar 02 '20 01:03 jmertic

Adding feedback from an LF project looking to use this...

What I have learned is that this particular technical process does not support Gitlab. But, if you want to create a mirror of the repo on Github, that should work fine. How does that sound?

Not good. Hey, we are talking about a link. I cannot believe that links (to gitlab) are not supported... If this is the case the technical process should be adapted. Creating a mirror does not make any sense - sorry.

jmertic avatar May 04 '20 20:05 jmertic

@jmertic which LF project uses GitLab? :)

caniszczyk avatar May 04 '20 20:05 caniszczyk

The feedback came from someone in CIP - not sure if they currently use it or plan to.

I do also think that CHAOSS is leaning towards GitLab.

On Mon, May 4, 2020 at 4:41 PM Chris Aniszczyk [email protected] wrote:

@jmertic https://github.com/jmertic which LF project uses GitLab? :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cncf/landscapeapp/issues/532#issuecomment-623694050, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACIOILOSMM2XWTSKGF5IJDRP4SAHANCNFSM4K7KUM7A .

jmertic avatar May 04 '20 20:05 jmertic

CIP currently uses Gitlab.

ncaidin avatar May 05 '20 13:05 ncaidin

I've had a number of projects that use GitLab want to be listed as well. Even if we can't pull anything from them, allowing gitlab links as "additional_repos" without erroring out would be a good start. For context, we don't only list LF projects on our landscape, we are using it to map out the entire space in which some of our projects function. So we have no control over which stack they use.

jennydove avatar Mar 15 '21 13:03 jennydove

@jennydove You can use other_repo_url instead of repo_url, it should not error out but it won't fetch any information regarding the repo either. This is for the main repo, not for additional_repos, but I could also add support for other_repo_url inside additional_repos.

jordinl avatar Mar 15 '21 17:03 jordinl

Oh that would be great!

jennydove avatar Mar 15 '21 21:03 jennydove

@jennydove changed the code to accept gitlab repos (or any URL really) for additional_repos. I've also changed it so you can use repo_url for gitlab instead of other_repo_url, that's both for the main repo and additional repos.

jordinl avatar Mar 29 '21 08:03 jordinl

amazing, thank you!

jennydove avatar Apr 06 '21 16:04 jennydove