hugo-netlify-starter icon indicating copy to clipboard operation
hugo-netlify-starter copied to clipboard

DCO Signoff for Template Repo

Open nate-double-u opened this issue 4 years ago • 3 comments
trafficstars

Problems:

  • Not all commits in cncf/hugo-netlify-starter are currently signed off using DCO.
  • When creating new repositories from the "Use this template" button, there is a single Initial commit created, which is not signed.

(Possible) fixes:

  • [ ] Go through and sign historic commits (though this isn't an issue for creating new repos from the template, unsigned commits can cause issues when pulling in upstream changes)
  • [ ] Add instructions to the starter (readme, or on the site itself), on how to setup DCO on new repositories, and provide a snippet to show how to sign the Initial commit

nate-double-u avatar Jul 26 '21 18:07 nate-double-u

Re: Use this template creating an initial, unsigned commit.

Another workaround would be to use Hugo's prescribed theme import method (git submodule). Presumably this would pull in only signed commits.

celestehorgan avatar Jul 26 '21 19:07 celestehorgan

Another workaround would be to use Hugo's prescribed theme import method (git submodule). Presumably this would pull in only signed commits.

Would that work with the site as is? Or would we need to "themeify" the starter in order to import it like that? (I think I'm pro making the starter a theme, but there may be some related conversation over in #64)

nate-double-u avatar Jul 26 '21 19:07 nate-double-u

I think having our own CNCF theme might be very nice but, unfortunately, I don't believe that we have the resources to develop and maintain it. I'd vote for use of Docsy (#64).

chalin avatar Jul 28 '21 15:07 chalin