glossary
glossary copied to clipboard
cncf
Add content/en/container-orchestration.md
Deploy Preview for cncfglossary ready!
| Name | Link |
|---|---|
| Latest commit | 842c930712b0018da09a28bf6e351145f949e0df |
| Latest deploy log | https://app.netlify.com/sites/cncfglossary/deploys/637d57999834e400081eb9e5 |
| Deploy Preview | https://deploy-preview-993--cncfglossary.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Asmit2952 thanks for the contribution. I will need you to have a little more patience :) It is on my list
@Asmit2952 thanks for your contribution. Before I review in detail, I would ask you to please use semantic line breaks. Also, please try to modify the Problem it addresses section according to the comment from Catherine.
@Asmit2952 thanks for your contribution. Before I review in detail, I would ask you to please use semantic line breaks. Also, please try to modify the Problem it addresses section according to the comment from Catherine.
Used semantic line breaks and tried to modify problem it addresses section. Please have a look at your convenience
@Asmit2952, are you still interested in working on this or should we take it from here?
Hey @CathPag I am still interested to work on this. I'm finding it a bit difficult to find the relevant content.
@Asmit2952, you can also leave it as is for someone else to pick up. That way, you helped move it forward but hand it off.
@Asmit2952, you can also leave it as is for someone else to pick up. That way, you helped move it forward but hand it off.
Hey @CathPag please just give me few more days. I want to work on this. Will update this PR soon.
Updated the "how it helps" part. Sorry for getting late on this as I got super busy and was unable to find reliable sources.
@Asmit2952 sorry for the delay, I added some suggestions. Most important are the semantic line breaks. I asked like 3 times to please add those. Please take a look, so that you get a feeling of what they look like. However, I simplified some content, please take a look as well and apply or decline the suggestions accordingly. I think we will need some editing from @CathPag afterward ;).
Hey @iamNoah1 I did add semantic line breaks in one of the commit. I added a break after every full stop. Didn't know that I had to add breaks after conjunctions as well.
@Asmit2952, are you still interested in working on this, or should we open it up for someone else?
Hey @CathPag, sorry for the delay. I missed the notification. I signed-off and committed most of the suggestions. Is there anything left to change? Can you go through the final doc once?
@Asmit2952 Also apparently the commits are not signed off correctly. Following the instructions of the DCO check, you should be able to fix that: https://github.com/cncf/glossary/pull/993/checks?check_run_id=9440776514.
@Asmit2952 Also apparently the commits are not signed off correctly. Following the instructions of the DCO check, you should be able to fix that: https://github.com/cncf/glossary/pull/993/checks?check_run_id=9440776514.
Hey @iamNoah1 , the DCO says the commits should be signed off locally. But I have made changes in web browser itself. Also I read a line "You are absolutely certain nobody else is doing any work based upon this branch", so will these affect yours and Catherine's commits?