glossary icon indicating copy to clipboard operation
glossary copied to clipboard

Add Sign Language Video Style Guide to index.md

Open Deafveloper opened this issue 1 year ago • 5 comments

added the sign language video style guide

Describe your changes

Added an anchor link under Audience and added the video style guide after getting started with a google doc

Related issue number or link (ex: resolves #issue-number)

related to issue #3040

Checklist before opening this PR (put x in the checkboxes)

  • [x] This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • [x] I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

Deafveloper avatar Sep 10 '24 18:09 Deafveloper

Deploy Preview for cncfglossary ready!

Name Link
Latest commit 6d1728918c1efce086aeced32be9dd4c9e8caed6
Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6723b5d34e9f9a00087f871a
Deploy Preview https://deploy-preview-3313--cncfglossary.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 10 '24 18:09 netlify[bot]

Hi @Deafveloper, this PR includes many commits from other contributors. :) I believe this happened because you've based your commit on a different branch instead of the dev-sign branch.

Let me check if simply changing the target branch to main branch will fix the issue. (I don't mind if we use the main branch directly.) If you're not too familiar with Git/GitHub branch concept, the above comment might be a bit confusing. But don't worry, I'll help you through it!

seokho-son avatar Sep 13 '24 03:09 seokho-son

Yes, the base branch of your local/feature is main. You can see this PR includes your commits only.

So, we either need to change the target branch of this PR (which I’ve already done) or change your base branch to dev-sign (though this isn't simple).

Why don’t we just use the main branch for this PR? We can decide when to merge it once the reviews are completed.

seokho-son avatar Sep 13 '24 03:09 seokho-son

@seokho-son Yes that is exactly what happened. I changed the branch after my commit. I’m still getting the hang of the Git/GitHub branch concepts, so I appreciate your patience.

I’m happy to learn and follow any steps you suggest.

Thanks again for your help!

Deafveloper avatar Sep 14 '24 00:09 Deafveloper

Thank you @tech-andgar! I added your suggestions. @jtjackson lmk wyt?

Deafveloper avatar Oct 27 '24 03:10 Deafveloper

LGTM 🙂

jtjackson avatar Oct 27 '24 14:10 jtjackson

LGTM!! :)

seokho-son avatar Nov 04 '24 10:11 seokho-son