glossary icon indicating copy to clipboard operation
glossary copied to clipboard

Published 20 hours ago • verified publisher icon cncf

add json output

Open robbymilo opened this issue 1 year ago • 5 comments
trafficstars

Describe your changes

Adds a JSON output of terms for each language.

Example:

  • https://deploy-preview-3165--cncfglossary.netlify.app/index.json
  • https://deploy-preview-3165--cncfglossary.netlify.app/pt-br/index.json

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • [x] This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • [x] I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

robbymilo avatar May 29 '24 11:05 robbymilo

Deploy Preview for cncfglossary ready!

Name Link
Latest commit 5980f970856f39a8e3a8654873c29d9b644d1ce0
Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/665713657405f30008e70775
Deploy Preview https://deploy-preview-3165--cncfglossary.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 29 '24 11:05 netlify[bot]

Hi @robbymilo, I may have missed a conversation somewhere, but what is the context of this PR? Why do we need json output for each language?

nate-double-u avatar Jun 04 '24 23:06 nate-double-u

@nate-double-u No conversation missed, at https://github.com/grafana we were planning on using this glossary for translations, so figured I would open a PR. Feel free to close if it is not wanted.

robbymilo avatar Jun 21 '24 09:06 robbymilo

Hi @robbymilo,

I am one of the maintainers of this repository. Your suggestion looks very nice to me, as this new interface will extend the usage of this project. LGTM!

If you share how your project utilize the glossary, it would be nice to other projects as well.

Anyway, I would like to double-check for any possible side effects with @cjyabraham, who is maintaining the hosting of glossary.cncf.io from CNCF team. @cjyabraham, could you please review this? :)

seokho-son avatar Jun 21 '24 10:06 seokho-son

@robbymilo friendly reminder to follow up on the question from @cjyabraham. Thanks

iamNoah1 avatar Aug 09 '24 16:08 iamNoah1

Thanks for this everyone. I'm going to close this PR as stale. @robbymilo, feel free to reopen if you're able to work on it again.

nate-double-u avatar May 27 '25 21:05 nate-double-u