glossary
glossary copied to clipboard
Add mboukhalfa, seifrajhi, adowair as codeowners for AR
Describe your changes
This commit will add mboukhalfa, seifrajhi, and adowair as codeowners for the Arabic CNCF glossary.
Related issue number or link (ex: resolves #issue-number
)
https://cloud-native.slack.com/archives/C02UFT8V256/p1714310155244299
Checklist before opening this PR (put x
in the checkboxes)
- [x] This PR does not contain plagiarism
- don’t copy other people’s work unless you are quoting and contributing it to them.
- [x] I have signed off on all commits
-
signing off (ex:
git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.
-
signing off (ex:
Deploy Preview for cncfglossary ready!
Name | Link |
---|---|
Latest commit | 560a1167e6d376558230ee481088270da9f517a5 |
Latest deploy log | https://app.netlify.com/sites/cncfglossary/deploys/6644e2951b736a000846de14 |
Deploy Preview | https://deploy-preview-3141--cncfglossary.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@mboukhalfa @seifrajhi @arezk84 @TarekMSayed
@arezk84 Did you notice the error message on the Changed Files tab ?
@mboukhalfa No, I assumed if this PR is accepted, these suggested owners will get the written permission.
From the GitHub Docs, it looks we we need to have write access to the repo first:
The people you choose as code owners must have write permissions for the repository. When the code owner is a team, that team must be visible and it must have write permissions, even if all the individual members of the team already have write permissions directly, through organization membership, or through another team membership.
...and this is defined in .github/settings.yml
:
https://github.com/cncf/glossary/blob/5c1f681879e41713a8e0ed556aafe18871ecc308/.github/settings.yml#L112-L123
Hei @adowair, all new approvers first need to read, understand and agree to the following discussion by commenting it: https://github.com/cncf/glossary/discussions/723
After that I need to open an PR in https://github.com/cncf/people to add the new approvers :)
cc @mboukhalfa @seifrajhi @arezk84 @TarekMSayed cc @jihoon-seo @seokho-son
/hold
@mboukhalfa and @seifrajhi also need to agree :)
Wait, please do not proceed with this yet.
@mboukhalfa friendly reminder to comment: #723
@mboukhalfa friendly reminder to comment: #723
done sorry for late reply