glossary icon indicating copy to clipboard operation
glossary copied to clipboard

[tr] Replace a Turkish approver

Open aliok opened this issue 11 months ago • 7 comments

Describe your changes

In favor of https://github.com/cncf/glossary/pull/2946

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • [x] This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • [x] I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

aliok avatar Mar 28 '24 07:03 aliok

Deploy Preview for cncfglossary ready!

Name Link
Latest commit d43bf585f8550a1c436f2ef44d265f79557971c5
Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/66051d734a57db0008ba2c11
Deploy Preview https://deploy-preview-3016--cncfglossary.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 28 '24 07:03 netlify[bot]

Created in favor of https://github.com/cncf/glossary/pull/2946

cc @halil-bugol @symys @rwxdash @eminalemdar

Thanks Halil for all the work so far!

aliok avatar Mar 28 '24 07:03 aliok

cc @seokho-son @iamNoah1 We need your approval in this PR

aliok avatar Mar 28 '24 07:03 aliok

Hi folks ! :)

  • We need to update config.yaml in https://github.com/cncf/people to get appropriate permission. (ex: https://github.com/cncf/people/pull/400)
  • The approver candidate (@symys) needs to check and confirm
    • #723

Hi @symys please check #723 and let us know you've read and understood it. In the meantime, I am going to open a PR to https://github.com/cncf/people to get appropriate permission.

@halil-bugol thanks for your contributions as an approver so far ! Hope you can continue contributions regardless of the role. :)

seokho-son avatar Mar 29 '24 01:03 seokho-son

Thanks. I am always here. :) @seokho-son

halil-bugol avatar Mar 29 '24 21:03 halil-bugol

Wait, please do not proceed with this yet.

github-actions[bot] avatar Apr 03 '24 00:04 github-actions[bot]

Adding hold label to give @symys a chance to confirm as per @seokho-son's post, and to make sure we've got the cncf/people PR correctly merged in.

nate-double-u avatar Apr 03 '24 00:04 nate-double-u

friendly reminder @symys @seokho-son.

iamNoah1 avatar Apr 12 '24 19:04 iamNoah1

ok I saw @symys agreed, @seokho-son what is the status of cncf people PR?

iamNoah1 avatar Apr 12 '24 19:04 iamNoah1

Oh, I got it

  • https://github.com/cncf/glossary/discussions/723#discussioncomment-9028433

seokho-son avatar Apr 15 '24 10:04 seokho-son

  • https://github.com/cncf/people/pull/410 (waiting for approval)

seokho-son avatar Apr 15 '24 10:04 seokho-son

Lets merge this then :) welcome @symys

iamNoah1 avatar Apr 16 '24 19:04 iamNoah1

Lets merge this then :) welcome @symys

Thank you so much :)

symys avatar Apr 16 '24 19:04 symys