glossary
glossary copied to clipboard
[tr] Replace a Turkish approver
Describe your changes
In favor of https://github.com/cncf/glossary/pull/2946
Related issue number or link (ex: resolves #issue-number
)
Checklist before opening this PR (put x
in the checkboxes)
- [x] This PR does not contain plagiarism
- don’t copy other people’s work unless you are quoting and contributing it to them.
- [x] I have signed off on all commits
-
signing off (ex:
git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.
-
signing off (ex:
Deploy Preview for cncfglossary ready!
Name | Link |
---|---|
Latest commit | d43bf585f8550a1c436f2ef44d265f79557971c5 |
Latest deploy log | https://app.netlify.com/sites/cncfglossary/deploys/66051d734a57db0008ba2c11 |
Deploy Preview | https://deploy-preview-3016--cncfglossary.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Created in favor of https://github.com/cncf/glossary/pull/2946
cc @halil-bugol @symys @rwxdash @eminalemdar
Thanks Halil for all the work so far!
cc @seokho-son @iamNoah1 We need your approval in this PR
Hi folks ! :)
- We need to update config.yaml in https://github.com/cncf/people to get appropriate permission. (ex: https://github.com/cncf/people/pull/400)
- The approver candidate (@symys) needs to check and confirm
- #723
Hi @symys please check #723 and let us know you've read and understood it. In the meantime, I am going to open a PR to https://github.com/cncf/people to get appropriate permission.
@halil-bugol thanks for your contributions as an approver so far ! Hope you can continue contributions regardless of the role. :)
Thanks. I am always here. :) @seokho-son
Wait, please do not proceed with this yet.
Adding hold label to give @symys a chance to confirm as per @seokho-son's post, and to make sure we've got the cncf/people PR correctly merged in.
friendly reminder @symys @seokho-son.
ok I saw @symys agreed, @seokho-son what is the status of cncf people PR?
Oh, I got it
- https://github.com/cncf/glossary/discussions/723#discussioncomment-9028433
- https://github.com/cncf/people/pull/410 (waiting for approval)
Lets merge this then :) welcome @symys
Lets merge this then :) welcome @symys
Thank you so much :)