glossary
glossary copied to clipboard
[ja] update redirect settings in Japanese Localization
Describe your changes
- add redirect rules from
/ja/microservices/
to/ja/microservices-architecture/
(same as English) - replace
/ja/microservices-architecture/
to/ja/microservices/
incontents/ja
dir
Background
When localizing, I often found it confusing to link to microservice pages because the destination page differs between Japanese and English.
English
https://github.com/cncf/glossary/blob/83d8503c36b5eed1206c7b72a0c99a78f366aa95/content/en/application-programming-interface.md?plain=1#L24
Japanese
https://github.com/cncf/glossary/blob/83d8503c36b5eed1206c7b72a0c99a78f366aa95/content/ja/application-programming-interface.md?plain=1#L24
I thought it would be best to update the redirect rules to resolve this issue.
Related issue number or link (ex: resolves #issue-number
)
No issue related to this PR
Checklist before opening this PR (put x
in the checkboxes)
- [x] This PR does not contain plagiarism
- don’t copy other people’s work unless you are quoting and contributing it to them.
- [x] I have signed off on all commits
-
signing off (ex:
git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.
-
signing off (ex:
Deploy Preview for cncfglossary ready!
Name | Link |
---|---|
Latest commit | 3f62b589927dc764cdcff74dd6edcf8896ce09a0 |
Latest deploy log | https://app.netlify.com/sites/cncfglossary/deploys/65fdcab3cafda00008892e4f |
Deploy Preview | https://deploy-preview-2999--cncfglossary.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Target pages on the deploy preview site:
- API: https://deploy-preview-2999--cncfglossary.netlify.app/ja/application-programming-interface/
- Distributed Apps: https://deploy-preview-2999--cncfglossary.netlify.app/ja/distributed-apps/
- FaaS: https://deploy-preview-2999--cncfglossary.netlify.app/ja/function-as-a-service/
- Monolithic Apps: https://deploy-preview-2999--cncfglossary.netlify.app/ja/monolithic-apps/
- mTLS: https://deploy-preview-2999--cncfglossary.netlify.app/ja/mutual-transport-layer-security/
- runtime: https://deploy-preview-2999--cncfglossary.netlify.app/ja/runtime/
- service mesh: https://deploy-preview-2999--cncfglossary.netlify.app/ja/service-mesh/
- service: https://deploy-preview-2999--cncfglossary.netlify.app/ja/service/
@Okabe-Junya Thank you for the PR.
One thing is that:
You updated /ja/microservices-architecture/
links to /ja/microservices/
, and I guess that you referred the upstream (English) files.
But IMO it is more appropriate to link to the final destination page (in this case, /lang/microservices-architecture/
), and so we don't need to link to transient URLs (in this case, /lang/microservices/
).
I tracked why the links in English pages have not been updated, and this is the related PRs:
-
#81:
microservices.md
was added. -
#206, #211, #1199, : some links to
/microservices/
were added. -
#1549: renamed
microservices.md
tomicroservices-architecture.md
, and added a redirection rule, but did not updated the links to/microservices/
.
So my suggestion is
- First we update some links that points
/microservices/
to point/microservices-architecture/
in all English files, and then - Revert some changes of this PR to point
/ja/microservices-architecture/
, not/ja/microservices/
.
I will open a PR that handles the first part of my suggestion.
Wait, please do not proceed with this yet.
Thank you @jihoon-seo, I agree with your suggestion!!
So, I will close this pr after #3009 merges, is it right??
@Okabe-Junya If #3009 gets merged, then please choose one option from:
- Revert some changes of this PR to point
/ja/microservices-architecture/
, not/ja/microservices/
. (Update this PR, not closing) - Or, close this PR and open a new one.
Either way is fine to me. 😊
@jihoon-seo
Thank you for your comment!!
I think "Revert some changes of this PR to point /ja/microservices-architecture/
, not /ja/microservices/
" means closing this PR. (Because if revert, no changes in this PR)
friendly ping @jihoon-seo :)
Can I close this pr? thank you
@Okabe-Junya Sure, please go ahead!