glossary icon indicating copy to clipboard operation
glossary copied to clipboard

Published 20 hours ago • verified publisher icon cncf

[EN] add WebAssembly

Open arunkarthicknm opened this issue 1 year ago • 12 comments

This resolves #1942

Checklist before opening this PR (put x in the checkboxes)

  • [x] This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • [x] I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

arunkarthicknm avatar Jun 06 '23 09:06 arunkarthicknm

Deploy Preview for cncfglossary ready!

Name Link
Latest commit a533102c7eb449c83adceb095713ffcaebb19a8e
Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/648c68cc1a1bb80008736e5d
Deploy Preview https://deploy-preview-2117--cncfglossary.netlify.app/webassembly
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 06 '23 09:06 netlify[bot]

Is it fine? @iamNoah1

arunkarthicknm avatar Jun 06 '23 11:06 arunkarthicknm

@CathPag @caniszczyk @JasonMorgan @iamNoah1 @jihoon-seo @seokho-son

arunkarthicknm avatar Jun 11 '23 13:06 arunkarthicknm

Thanks for your contribution, @arunkarthicknm. We are currently working our way through our backlog. This is on our to-do list, but there are a few terms that need to be reviewed before yours. Thanks for your patience!

CathPag avatar Jun 11 '23 21:06 CathPag

Sure @CathPag

arunkarthicknm avatar Jun 12 '23 05:06 arunkarthicknm

Hi @arunkarthicknm, it's been a couple of weeks since we've seen any activity on this PR, and I wanted to check-in. Please don't hesitate to ask if you have any questions or need further clarification on any of the points I've raised. We're here to help.

nate-double-u avatar Jul 12 '23 20:07 nate-double-u

Agreed with @nate-double-u on the suggested changes. If no objections I'll noodle on some recommended wording for the content.

hlipsig avatar Jan 25 '24 18:01 hlipsig

No objections, please noodle 🙂

nate-double-u avatar Jan 26 '24 03:01 nate-double-u

What is the status here? @nate-double-u

iamNoah1 avatar Mar 08 '24 13:03 iamNoah1

@hlipsig, you were working on a review, but had some questions around how best to provide the feedback. Did we land on a best practice?

nate-double-u avatar Mar 08 '24 19:03 nate-double-u

@nate-double-u @hlipsig my suggestion would be to add suggestions via the suggestion feature so that they can easily be added (committed) through the web ui. And also as the author is not responsive anymore we should just go on and make the suggested changes ourselves. What you think @nate-double-u, wanna take over? Or @arunkarthicknm wants to follow up?

iamNoah1 avatar Apr 08 '24 18:04 iamNoah1

I'm happy to take it over. @hlipsig, I'm also happy to work with you to get your suggestions in, I'd hate for you to have done work that didn't get considered 🙂

nate-double-u avatar Apr 08 '24 18:04 nate-double-u