glossary icon indicating copy to clipboard operation
glossary copied to clipboard

[Spanish] localize 'Firewall'

Open tinniaru3005 opened this issue 2 years ago • 2 comments

Describe your changes

Converted firewall.md to Spanish.

Related issue number or link (ex: resolves #issue-number)

resolves #1375 Closes #1375

Checklist before opening this PR (put x in the checkboxes)

  • [x] This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • [x] I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

tinniaru3005 avatar Oct 20 '22 17:10 tinniaru3005

Deploy Preview for cncfglossary ready!

Name Link
Latest commit 98b48a36efd2813eb0733ffe6f63d789931faa05
Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/638b8cc913568800088a3f37
Deploy Preview https://deploy-preview-1404--cncfglossary.netlify.app/es/firewall
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 20 '22 17:10 netlify[bot]

Hey @electrocucaracha, I cannot understand how the extra changes are getting added. Can you please guide me on how to avoid it and how I can I rectify it here?

tinniaru3005 avatar Oct 20 '22 17:10 tinniaru3005

Hey @electrocucaracha, I cannot understand how the extra changes are getting added. Can you please guide me on how to avoid it and how I can I rectify it here?

It seems those changes are coming from the main branch, so when the PR is created targeting to dev-es it's when they appear.

electrocucaracha avatar Oct 20 '22 23:10 electrocucaracha

Thanks @electrocucaracha for explaining me. Are the changes fine now?

tinniaru3005 avatar Oct 20 '22 23:10 tinniaru3005

Thanks @electrocucaracha for explaining me. Are the changes fine now?

Apparently, the spellchecker reports the enrutamiento and microservices words are missing in the list

electrocucaracha avatar Oct 31 '22 18:10 electrocucaracha

Thanks @electrocucaracha for explaining me. Are the changes fine now?

Apparently, the spellchecker reports the enrutamiento and microservices words are missing in the list

Can you please guide me on how I can make those changes

tinniaru3005 avatar Oct 31 '22 18:10 tinniaru3005

Thanks @electrocucaracha for explaining me. Are the changes fine now?

Apparently, the spellchecker reports the enrutamiento and microservices words are missing in the list

Can you please guide me on how I can make those changes

Sure, with the latest additions, it seems like enrutamiento is the only missing word. This word has to be added (in alphabetical order) in this file. If you use the terminal, you can execute the following bash instructions

$ git remote -v
origin  [email protected]:electrocucaracha/glossary.git (fetch)
origin  [email protected]:electrocucaracha/glossary.git (push)
upstream        https://github.com/cncf/glossary (fetch)
upstream        https://github.com/cncf/glossary (push)
$ git branch
* dev-es
  main
$ git pull upstream dev-es
$ gh pr checkout 1404
$ git rebase dev-es

You'll need to solve some rebase issues here before adding the missing word.

$ echo "enrutamiento" >> content/es/.wordlist.txt
$ sort -f -o content/es/.wordlist.txt content/es/.wordlist.txt

electrocucaracha avatar Oct 31 '22 19:10 electrocucaracha

Hey @electrocucaracha, is it fine now?

tinniaru3005 avatar Nov 04 '22 08:11 tinniaru3005

Hey @electrocucaracha, Can the PR be merged now?

tinniaru3005 avatar Nov 15 '22 06:11 tinniaru3005

Hey @electrocucaracha. Is it good to merge now?

tinniaru3005 avatar Nov 29 '22 17:11 tinniaru3005

Hey @electrocucaracha. Is it good to merge now?

It looks good to me, the Squash and merge button is disabled on my side. Maybe, we need to wait for @krol3 review.

electrocucaracha avatar Nov 29 '22 18:11 electrocucaracha

@tinniaru3005 it seems like the suggestion that @krol3 made wasn't applied. Could you use firewall instead of cortafuegos? More likely, the word list will be affected.

electrocucaracha avatar Dec 03 '22 00:12 electrocucaracha

Hey @electrocucaracha is it fine now?

tinniaru3005 avatar Dec 03 '22 17:12 tinniaru3005

@tinniaru3005 it seems that this PR has more not related changes, can you verify it and fix it?

electrocucaracha avatar Dec 04 '22 21:12 electrocucaracha

Hey @electrocucaracha when I fork only the main branch gets forked. I am facing this issue in all the PRs. Can you please tell me how I can fork a particular branch.

tinniaru3005 avatar Dec 04 '22 22:12 tinniaru3005

Hey @electrocucaracha when I fork only the main branch gets forked. I am facing this issue in all the PRs. Can you please tell me how I can fork a particular branch.

Your Spanish translation PRs have to be based on dev-es instead of main, there are some information here

electrocucaracha avatar Dec 05 '22 15:12 electrocucaracha

Hey @electrocucaracha when I fork only the main branch gets forked. I am facing this issue in all the PRs. Can you please tell me how I can fork a particular branch.

Your Spanish translation PRs have to be based on dev-es instead of main, there are some information here

@tinniaru3005 Please review your PR, you need to create a branch from dev-es and add your changes. cc: @electrocucaracha

krol3 avatar Dec 13 '22 13:12 krol3

Hey @electrocucaracha when I fork only the main branch gets forked. I am facing this issue in all the PRs. Can you please tell me how I can fork a particular branch.

Your Spanish translation PRs have to be based on dev-es instead of main, there are some information here

@tinniaru3005 Please review your PR, you need to create a branch from dev-es and add your changes.

krol3 avatar Dec 13 '22 13:12 krol3

Hi @tinniaru3005 ! how are you? Could you resolve the conflicts? do you need help ?

krol3 avatar Jan 10 '23 17:01 krol3