glossary
glossary copied to clipboard
[Spanish] localize 'Firewall'
Describe your changes
Converted firewall.md
to Spanish.
Related issue number or link (ex: resolves #issue-number
)
resolves #1375 Closes #1375
Checklist before opening this PR (put x
in the checkboxes)
- [x] This PR does not contain plagiarism
- don’t copy other people’s work unless you are quoting and contributing it to them.
- [x] I have signed off on all commits
-
signing off (ex:
git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.
-
signing off (ex:
Deploy Preview for cncfglossary ready!
Name | Link |
---|---|
Latest commit | 98b48a36efd2813eb0733ffe6f63d789931faa05 |
Latest deploy log | https://app.netlify.com/sites/cncfglossary/deploys/638b8cc913568800088a3f37 |
Deploy Preview | https://deploy-preview-1404--cncfglossary.netlify.app/es/firewall |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Hey @electrocucaracha, I cannot understand how the extra changes are getting added. Can you please guide me on how to avoid it and how I can I rectify it here?
Hey @electrocucaracha, I cannot understand how the extra changes are getting added. Can you please guide me on how to avoid it and how I can I rectify it here?
It seems those changes are coming from the main
branch, so when the PR is created targeting to dev-es
it's when they appear.
Thanks @electrocucaracha for explaining me. Are the changes fine now?
Thanks @electrocucaracha for explaining me. Are the changes fine now?
Apparently, the spellchecker reports the enrutamiento
and microservices
words are missing in the list
Thanks @electrocucaracha for explaining me. Are the changes fine now?
Apparently, the spellchecker reports the
enrutamiento
andmicroservices
words are missing in the list
Can you please guide me on how I can make those changes
Thanks @electrocucaracha for explaining me. Are the changes fine now?
Apparently, the spellchecker reports the
enrutamiento
andmicroservices
words are missing in the listCan you please guide me on how I can make those changes
Sure, with the latest additions, it seems like enrutamiento
is the only missing word. This word has to be added (in alphabetical order) in this file. If you use the terminal, you can execute the following bash instructions
$ git remote -v
origin [email protected]:electrocucaracha/glossary.git (fetch)
origin [email protected]:electrocucaracha/glossary.git (push)
upstream https://github.com/cncf/glossary (fetch)
upstream https://github.com/cncf/glossary (push)
$ git branch
* dev-es
main
$ git pull upstream dev-es
$ gh pr checkout 1404
$ git rebase dev-es
You'll need to solve some rebase issues here before adding the missing word.
$ echo "enrutamiento" >> content/es/.wordlist.txt
$ sort -f -o content/es/.wordlist.txt content/es/.wordlist.txt
Hey @electrocucaracha, is it fine now?
Hey @electrocucaracha, Can the PR be merged now?
Hey @electrocucaracha. Is it good to merge now?
Hey @electrocucaracha. Is it good to merge now?
It looks good to me, the Squash and merge
button is disabled on my side. Maybe, we need to wait for @krol3 review.
@tinniaru3005 it seems like the suggestion that @krol3 made wasn't applied. Could you use firewall
instead of cortafuegos
? More likely, the word list will be affected.
Hey @electrocucaracha is it fine now?
@tinniaru3005 it seems that this PR has more not related changes, can you verify it and fix it?
Hey @electrocucaracha when I fork only the main branch gets forked. I am facing this issue in all the PRs. Can you please tell me how I can fork a particular branch.
Hey @electrocucaracha when I fork only the main branch gets forked. I am facing this issue in all the PRs. Can you please tell me how I can fork a particular branch.
Your Spanish translation PRs have to be based on dev-es
instead of main
, there are some information here
Hey @electrocucaracha when I fork only the main branch gets forked. I am facing this issue in all the PRs. Can you please tell me how I can fork a particular branch.
Your Spanish translation PRs have to be based on
dev-es
instead ofmain
, there are some information here
@tinniaru3005 Please review your PR, you need to create a branch from dev-es
and add your changes.
cc: @electrocucaracha
Hey @electrocucaracha when I fork only the main branch gets forked. I am facing this issue in all the PRs. Can you please tell me how I can fork a particular branch.
Your Spanish translation PRs have to be based on
dev-es
instead ofmain
, there are some information here
@tinniaru3005 Please review your PR, you need to create a branch from dev-es
and add your changes.
Hi @tinniaru3005 ! how are you? Could you resolve the conflicts? do you need help ?