cncf
Add content/en/hypervisor
adding the term hypervisor to the glossary
Signed-off-by: Kiran Satya Raj [email protected]
Describe your changes
Related issue number or link (ex: resolves #issue-number)
Checklist before opening this PR (put x in the checkboxes)
- [x] This PR does not contain plagiarism
- don’t copy other people’s work unless you are quoting and contributing it to them.
- [x] I have signed off on all commits
- signing off (ex:
git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".
- signing off (ex:
Deploy Preview for cncfglossary ready!
| Name | Link |
|---|---|
| Latest commit | 529ed213ebc9465892ee434c252e6cfa4b889aa6 |
| Latest deploy log | https://app.netlify.com/sites/cncfglossary/deploys/636f497c1d9dc400089ce9ce |
| Deploy Preview | https://deploy-preview-1385--cncfglossary.netlify.app/hypervisor |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for suggesting the changes @NitishKumar06, they were relevant so I've committed them.
I'm afraid if the website contains some kind of checks where the build gets failed due to a large number of commits raised. I have no idea till now if such checks exists. In order to keep on the safer side, It could be better if @KiranSatyaRaj squash all the commits. WDYT @iamNoah1 ?
Thanks @NitishKumar06
large number of commits does not incur build failures. But, since meaningless commits are not desired, squashing commits in a PR is desired as @NitishKumar06 suggested. By the way, contributor doesn't have to keep squashing or amending commits for every PR updates. The squashing can be done by contributor just before this PR is ready to be merged.
Anyway, an approver will use squash and merge method to merge this PR.
@KiranSatyaRaj please let me know whenever you have incorporated or considered the suggested feedback and if we should took a look again :)
Sure, there were a few points I mentioned in the discussion regarding the term I just wanted to check whether they were neutral and straightforward, that's fine I'll work my way through it and get back to you with the applied changes as soon as possible.
Hey @iamNoah1 I made, can you please go through it and let me know the changes required to make it better.