dot-org-hugo-theme icon indicating copy to clipboard operation
dot-org-hugo-theme copied to clipboard

Fix entity escaping in rss.xml

Open woefe opened this issue 1 year ago • 6 comments

Fixes the entity escaping in the RSS item description. Uses the same escaping mechanism as the default Hugo rss template.

transform.XMLEscape requires Hugo 0.121.0 or newer. https://gohugo.io/functions/transform/xmlescape/

woefe avatar Apr 18 '24 07:04 woefe

Deploy Preview for dot-org-hugo-theme-demo-thetwopct failed.

Name Link
Latest commit 8442de9a1fcca1be8f34526abccca12376a7b9d4
Latest deploy log https://app.netlify.com/sites/dot-org-hugo-theme-demo-thetwopct/deploys/6620d076b9a82c00083802e9

netlify[bot] avatar Apr 18 '24 07:04 netlify[bot]

Deploy Preview for dot-org-hugo-theme-demo failed. Why did it fail? →

Name Link
Latest commit 8442de9a1fcca1be8f34526abccca12376a7b9d4
Latest deploy log https://app.netlify.com/sites/dot-org-hugo-theme-demo/deploys/6620d076b9a82c00083802ee

netlify[bot] avatar Apr 18 '24 07:04 netlify[bot]

What's your policy on the Hugo version? I see the netlify bot is currently building with 0.115.4.

An alternative fix could be to use | html as in older versions of the default hugo template: https://github.com/gohugoio/hugo/commit/b4c5df42ff7d2542a661cf06b7a7acb03282bc5a#diff-76032d349eedf06717453a1b01a0ebab2b4324b19533b2825f18eb9a2a377e6b

woefe avatar Apr 18 '24 08:04 woefe

@cjyabraham - just curious, why you're not using the Hugo RSS template?

chalin avatar May 14 '24 21:05 chalin

@cjyabraham - just curious, why you're not using the Hugo RSS template?

@thetwopct, any thoughts?

cjyabraham avatar May 15 '24 09:05 cjyabraham

@cjyabraham - just curious, why you're not using the Hugo RSS template?

Tbh, I can't remember now, but pretty sure it wasn't showing the content I wanted it too. I can try switching back if I get time. Also @woefe thanks for your PR, and sorry for not approving it yet, I haven't had a chance to work on this theme recently.

thetwopct avatar May 15 '24 10:05 thetwopct