artwork icon indicating copy to clipboard operation
artwork copied to clipboard

include 'Knative' project name in horizontal and stacked artwork

Open dprotaso opened this issue 3 months ago • 15 comments

dprotaso avatar Sep 04 '25 16:09 dprotaso

cc @aliok @evankanderson @matzew (Knative Steering)

dprotaso avatar Sep 04 '25 16:09 dprotaso

Looks good to me.

I thought there might be links to existing images and looked for ways to find those references. I wasn't able to find a good way.

aliok avatar Sep 05 '25 06:09 aliok

/lgtm

aliok avatar Sep 05 '25 06:09 aliok

Dave, do you want me to PR those changes to your branch?

evankanderson avatar Oct 28 '25 20:10 evankanderson

Sure if that’s easier for you to do

On Tue, Oct 28, 2025 at 16:47 Evan Anderson @.***> wrote:

evankanderson left a comment (cncf/artwork#587) https://github.com/cncf/artwork/pull/587#issuecomment-3458420786

Dave, do you want me to PR those changes to your branch?

— Reply to this email directly, view it on GitHub https://github.com/cncf/artwork/pull/587#issuecomment-3458420786, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAERARNEWDIFKLSOAU2ET33Z7I5NAVCNFSM6AAAAACFURQ7PCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINJYGQZDANZYGY . You are receiving this because you were mentioned.Message ID: @.***>

dprotaso avatar Oct 28 '25 20:10 dprotaso

https://github.com/cncf/artwork/pull/608 won't actually affect this PR, I thought it might, but this PR just affects the logos.

nate-double-u avatar Oct 29 '25 21:10 nate-double-u

OK - the svg now has the embedded font

dprotaso avatar Nov 07 '25 20:11 dprotaso

Thanks for the update @dprotaso; however, there are still some updates I’d like to ask for. The SVG files appear to be cut off on the right, and the PNG files appear to have a slight outline on the text:

cncf-artworkexamplesincubating md at knative-logo-updates · dprotasocncf-artwork

nate-double-u avatar Nov 09 '25 03:11 nate-double-u

@nate-double-u interesting mine shows up as

Screenshot 2025-11-08 at 10 44 31 PM

Where are you viewing that?

@evankanderson do you know what might be happening with the font embedding?

dprotaso avatar Nov 09 '25 03:11 dprotaso

I'm using the GitHub UI. My first screen cap was using my ipad, which put them on a dark background which made it easier to see the haloing, but you can see the cutoff better here:

Screenshot 2025-11-08 at 8 21 24 PM

nate-double-u avatar Nov 09 '25 04:11 nate-double-u

You can also see a "deploy preview" here: https://github.com/dprotaso/cncf-artwork/blob/knative-logo-updates/examples/incubating.md#knative-logos

nate-double-u avatar Nov 09 '25 04:11 nate-double-u

Interesting, I don't see the cutoff (Android) Screenshot_20251109-015323.GitHub.png

evankanderson avatar Nov 09 '25 06:11 evankanderson

@dprotaso, I'm not sure why it wasn't added initially, but here's the pre-submission checklist that usually gets added to a PR (it has info about the autocrop tool):

Pre-submission checklist:

If you're adding a new project to the repo, please confirm each of these actions has been completed:

[ ] Artwork is supplied in both PNG and SVG formats. [ ] SVGs are real vector-based files. Test and optimize them at https://autocrop.cncf.io/ before submitting. [ ] Artwork includes 3 layouts: horizontal (landscape), stacked, and icon. [ ] At least 3 versions of the artwork are provided: color, black, and white. [ ] Files follow the existing repo folder and naming conventions. [ ] The correct examples/file.md is updated with a section for the logos added, in A-Z order. [ ] A link to the new logo section is added to the main README.md, in A-Z order.

Note: Updates to this repo require two approvals to be merged in. One from a CNCF staff member, and the other from a project maintainer whose project's artwork is being updated. We can bypass branch protections for PRs made by maintainers.

nate-double-u avatar Nov 12 '25 14:11 nate-double-u

So I ran the SVGs through the https://autocrop.cncf.io/ tool, and it says that there are PNGs embedded in the SVG files. This would explain the weird cropping I'm seeing (and the varibility I'm seeing between browsers and computers).

Could you please update the files to be pure SVG, and test using the autocrop.cncf.io site?

There aren't PNGs embedded in the SVG file, but there is a font embedded. I wonder if autocrop is getting confused between the two.

evankanderson avatar Dec 13 '25 05:12 evankanderson

Autocrop says:

Fails with an error on SVGs that contain a or element since the text will not render reliably if the specified fonts are not installed (instead, you can convert the text to an image so that it will reliably render anywhere)

This does contain a text, but it also includes the font.

evankanderson avatar Dec 13 '25 05:12 evankanderson