artwork icon indicating copy to clipboard operation
artwork copied to clipboard

Published 20 hours ago • verified publisher icon cncf

Addition of the Kubestronaut logos

Open huats opened this issue 1 year ago • 4 comments

Addition of the various Kubestronaut logos.

huats avatar Apr 16 '24 21:04 huats

I think I have address your concerns @cjyabraham. Thanks for your new review

huats avatar Apr 17 '24 14:04 huats

Some of the SVGs still have a lot of whitespace. Did you pass them all through the autocrop service? Screenshot 2024-04-18 at 10 17 26 AM

cjyabraham avatar Apr 18 '24 03:04 cjyabraham

I did ! (I just redo it again) ! Maybe autocrop is not enough ?

huats avatar Apr 18 '24 15:04 huats

There's something weird going on, when I view your recent commit, it looks like this, which looks correct:

Screenshot 2024-04-19 at 8 26 57 AM

But when I view the Files changed for this PR, I see the same SVG like this with a lot more whitespace above and below: Screenshot 2024-04-19 at 8 27 10 AM

Maybe we should just merge and then see what happens??

cjyabraham avatar Apr 19 '24 01:04 cjyabraham

Is this good to merge @huats @cjyabraham?

krook avatar May 20 '24 19:05 krook

Sure. I'll merge it in.

cjyabraham avatar May 21 '24 03:05 cjyabraham