Chase Naples

Results 43 comments of Chase Naples

@glbrntt Thanks for the feedback. Sure, I'll make those changes and update the PR!

Thanks for the questions / feedback @rgoldberg ! - Does this preclude digit flags? Yes in this PR: standalone "-" or "-." are always classified as values, so numeric short/old-style-long...

@rgoldberg do you want me to update the PR with this new criteria?

@rgoldberg Ah got it! Yeah of course, I'll wait for feedback from one of the POs. Thanks a bunch for your suggestions! I'm not entirely sure which approach is best...

Thanks for the feedback @feltech! I've updated the implementation to address the Docker compatibility concerns: ## Changes Made **🔧 Improved Docker Compatibility:** - Default to `--devices nvidia.com/gpu=all` for NVIDIA GPUs...

Thanks for the clarification, and you're absolutely right — `minikube` doesn't support `--devices`. I've updated the PR to remove the `--devices` path and always pass `--gpus all` to `minikube start`...

I have read the CLA Document and I hereby sign the CLA