Colin Rofls

Results 167 comments of Colin Rofls

@nicoburns what did you use to generate those graphs?

@qxliu76 one of your tests is failing on this patch, how do you rebuild your test files?

If format 0 is what we need to generate I think that's a good starting point, and we can revisit when the need arises? I'll take a look.

My assumption while writing this (and I did some godbolt'ing at the time) was that this would all be optimized away, but it's definitely possible it is hurting compile times....

> Based on fontations' history, I'm assuming there will still be regular releases that are breaking from an API perspective (if not from a behaviour perspective)? So we should expect...

> On the other hand, I had noticed that fontations crates were making breaking particularly frequently which has caused a lot of releases in downstream crates I use just to...

good catch, would you like to PR a fix?

I'll block out some time to take a look at this tomorrow!

I'll think about this more in the light of day, but generally I think you're on the right path. One additional idea that behdad mentioned is that it would be...

yea that is a bit annoying, and I'm not sure what makes the most sense. - on the `write-fonts` side, `char` is nice, since it makes it impossible for garbage...