geomag icon indicating copy to clipboard operation
geomag copied to clipboard

Published 20 hours ago • verified publisher icon cmweiss

Refactor to be more pythonic

Open sposs opened this issue 7 years ago • 3 comments

sposs avatar Oct 03 '16 15:10 sposs

Thanks, I'll take a look at your pull request in detail. It may take me a few days to dig in. Would you please give me a bit more detail on your changes. More pythonic is nice to know but I need more explanation, please.

cmweiss avatar Oct 03 '16 16:10 cmweiss

I moved the things around (split code and tests), changed the package structure to make it more standard, as there was an unnecessary level. I also fixed some PEP8 conventions. I simplified operations (a = a+1 becomes a += 1). Nothing else.

sposs avatar Oct 03 '16 16:10 sposs

#3 is much better than this one...

sposs avatar Oct 08 '16 15:10 sposs