Callum Waters

Results 248 comments of Callum Waters

Looping back to this I think we should first focus on swapping out the verification functions for the standard light client ones. Then further to that we can assess: -...

Hey @odeke-em, notice this is against `master` which we're no longer using in favour of `main` (`master` is staying around just for posterity). Do you mind reusing your static analysis...

Would also like to add service discovery as being an important aspect (ref: https://github.com/tendermint/tendermint/issues/5742). Currently if 5 nodes in a network from 100 are providing snapshots it can be difficult...

> Is this a sub-issue of https://github.com/tendermint/tendermint/issues/9396? yes you should see it there

That makes sense to me. I think ideally we want two separate RPC servers - one designed to be used by node operators and the other designed to be used...

This is the first PR. The person who takes this on should also be wary of the migration script work to ensure that nodes detect and can automatically upgrade to...

> Block events fire when block minted, transaction events fire when transaction submitted. Transaction events only fire when the block is minted. This is because the events are often dependent...

`DeduplicateBatch` if I'm not mistaken is more a case of the kv indexer as it indexes on tx hashes (which there could be multiple duplicates committed with different results and...

> I see messages like > txindex/indexer_service.go:88 deduplicate batch {"height": 412} Just realised that the actual error isn't being logged. Will push a small patch for that

Ok, after digging around it seems that we need to move the deduplication logic into the kvIndexer only because as it's currently implemented any transaction that is committed but not...