Christian Nicolai

Results 130 comments of Christian Nicolai

I also see changes to `timeout-minutes` in zeebe-ci.yml that are unnecessary: * `jobs.integration-tests.timeout-minutes`: from 20 to 40 while the job currently takes ~17-20min, probably 30min is more reasonable * `jobs.smoke-tests.timeout-minutes`:...

> These `paths-ignore`s are going to be fixed [here](https://github.com/camunda/camunda/pull/20613/files#diff-88e3a45c7e969bdeb09ec61c245254cbfa64b5c09866c5f640ff941092910c10R8-R16) Thanks! > I think most of these can be moved to some sub dir like .github/optimize. WDYT? I just don't know...

> @cmur2 Was there a specific reason you requested a review? All required checks seem to be passing. We technically need a review to progress and Renovate auto-approve didn't work...

> * Zeebe team gets notification via Slack like in [example](https://camunda.slack.com/archives/C013MEVQ4M9/p1724348100216119) via GHA glue code that triggers when steps.analyze-test-run.outputs.flakyTests != '' @npepinpe given the movement of https://github.com/camunda/camunda/pull/21727 which removes all...

Starting Friday, 2024-08-30 around noon UTC all jobs that detect flaky tests do exit with status `success` and not with `failure` anymore so rollout was successful: ![image](https://github.com/user-attachments/assets/ad168a8a-cf8d-4a25-90b5-b158b37b62bd) I will look...

@npepinpe given the way [the filter is coded](https://github.com/camunda/camunda/blob/9524ebc02e639f335f73daf85b770b86067c4d0f/.github/actions/paths-filter/action.yml#L81) it is the expected result that the protobuf backwards compatibility check runs on `push` events. I started the best practice to always...

Small change so should be quick to implement (~1 hour) /cc @megglos @npepinpe

This happened again in https://github.com/camunda/camunda/actions/runs/10884581027/job/30200228453 (timeout after 6 hours only)

Without actively looking for it, found a build where it happened again: https://github.com/camunda/camunda/actions/runs/11673124267/job/32503262847 Since the fix is known and very straightforward, @megglos can we make progress on this please?

@rodrigo-lourenco-lopes since you asked how to test this PR: I looked at the CI runs and can see e.g. in https://github.com/camunda/camunda/actions/runs/10598267866/job/29370652128?pr=21685 that the new composite action is used as expected...