PAM icon indicating copy to clipboard operation
PAM copied to clipboard

Published 20 hours ago • verified publisher icon cmuparlay

win32 compatibility

Open imoldfella opened this issue 5 years ago • 2 comments

Are you interested in pull requests? I've a few patches that let me compile with visual studio, but I wasn't sure if you would be interested in supporting this as a library or if it sits as is to represent your dissertation work. Fabulous dissertation by the way! All the best with your new job.

imoldfella avatar Nov 21 '19 18:11 imoldfella

Yes it would be great if it can work with VS! The current version can run in windows sequentially, but we haven't made it parallel so far. We appreciate it if you have patches that can make it work with visual studio :)

Also thanks for being interested in my work! Good luck to you too!

syhlalala avatar Nov 22 '19 02:11 syhlalala

It turns out most of the patches are required to pbbslib; that is included by submodule here. I left a small pull request to see if anyone is interested, but no response so far (it's only been a few days). I'm not in a hurry, but if anyone wants this faster let me know and I could always fork it. The changes are pretty straightforward. MSVC is apparently a lot picker about saying "inline" everywhere compared to GCC. Almost everything else can be done with single MSVC specific header. OpenMP is still 2.0 on MSVC, and RIP Cilk, but Homegrown works well enough that I haven't tried to port to TBB or Concurrency Runtime yet.

imoldfella avatar Nov 25 '19 22:11 imoldfella