tetrad
tetrad copied to clipboard
cmu-phil
BPC is missing a critical check
Both BPC and FOFC require a preprocessing step that checks to see whether the marginal graphical model on the measured variables is complete--or nearly so--and only runs the latent variable search of BPC or FOFC if it is complete. I have asked Madelyn to look into this problem, but we may have to hand it off.
I fixed this for FOFC--jdramsey
@cg09 @mglymour Asking again, was this fixed? I know it was fixed in Madelyn's code, but was that ever pushed to development?
Only Madelyn would know.
On Thu, Feb 20, 2020 at 10:33 AM Joseph Ramsey [email protected] wrote:
@cg09 https://github.com/cg09 @mglymour https://github.com/mglymour Asking again, was this fixed? I know it was fixed in Madelyn's code, but was that ever pushed to development?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cmu-phil/tetrad/issues/1162?email_source=notifications&email_token=AD4Y3OIMDD6ISRQAOSVLAS3RD2PD7A5CNFSM4HYRV46KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMOWYFA#issuecomment-589130772, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4Y3OKWK3RKSLKQZCA7FJ3RD2PD7ANCNFSM4HYRV46A .
No, we have not implemented a satisfactory check, although we have sketched a procedure.
On Thu, Feb 20, 2020 at 10:33 AM Joseph Ramsey [email protected] wrote:
@cg09 https://github.com/cg09 @mglymour https://github.com/mglymour Asking again, was this fixed? I know it was fixed in Madelyn's code, but was that ever pushed to development?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cmu-phil/tetrad/issues/1162?email_source=notifications&email_token=AD4Y3OIMDD6ISRQAOSVLAS3RD2PD7A5CNFSM4HYRV46KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMOWYFA#issuecomment-589130772, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4Y3OKWK3RKSLKQZCA7FJ3RD2PD7ANCNFSM4HYRV46A .