peloton icon indicating copy to clipboard operation
peloton copied to clipboard

Fix travis build to actually use gcc5

Open tcm-marcel opened this issue 6 years ago • 5 comments

Travis vehemently ignores our environmental variables for gcc5, but setting it in front of the cmake command works.

@pmenon gave this hint before, but it was forgotten in #1311.

tcm-marcel avatar Apr 25 '18 14:04 tcm-marcel

@tcm-marcel For consistency, you should set CC=gcc-5, too.

Also, I wonder if you can export the CXX and CC variables before invoking the build? Then the cmake invocation should remain the same and, hopefully, make the environment setup clear.

pmenon avatar Apr 25 '18 15:04 pmenon

Coverage Status

Coverage decreased (-77.9%) to 0.0% when pulling 29ba99e574c783ec253cc2d76eac36acf0d810e5 on tcm-marcel:build/deprecate-gcc48 into bf7ff625e86f2917bc939f85c41e810eec3588ec on cmu-db:master.

coveralls avatar Apr 25 '18 15:04 coveralls

@pmenon I just wanted to show you that this happens already when specifying it in the travis file. But then I saw that in fact it does happen, but the variables get overridden a few lines later.

grafik

We can again override it just before the invocation.

tcm-marcel avatar Apr 25 '18 15:04 tcm-marcel

@tcm-marcel Huh, then it looks like the stuff in env is getting overridden. Does it make sense to move everything currently in env into before_script as export's?

I just found this as an example.

pmenon avatar Apr 25 '18 15:04 pmenon

The tests fail because of an incompatibility between the pre-compiled tensorflow version and protobuf, which is already discussed on the mailing list. I will leave this open, until we have a solution/workaround for this.

tcm-marcel avatar Apr 26 '18 15:04 tcm-marcel