I am not sure if this should be QoL or Balance change, so i keep it balance because it allows you to do thing that was not possible before because of wonky code.

About the pull request

Allows Abduction ability to be casted at same tile as barricade, flipped tables and glass window panes (as long as they don't face ability casting direction), and also allows abduction to be cast trought low obstacles, such as:

window frames
small long crates
normal long crates
platform edges
disposal units (bins)
hydro trays (botany)
janitor cart
trash cans (hybrisia)
line nexter (hybrisia)
tables (not flipped)

Explain why it's good for the game

As person who enjoyed playing oppressor i found it frustrating when cade was destroyed at corner, so cade facing towards you was open, but at same tile, there was another cade facing 90 degree in other direction, so when you cast ability it gets blocked, same follows for other small obstacles, its so annoying when you want to cast through tables, trays or crates and your ability get blocked by them, this change allows for abductor main ability to be more usefull.

With this change now you can cast ability at tiles that have barricade in them as long as they dont face casting direction, same follows for flipped tables and window panes.

Testing Photographs and Procedure

>Click Here

Some testing done with abduct:

https://github.com/user-attachments/assets/1b0fc84d-517b-426f-b279-e6adde07abaf

https://github.com/user-attachments/assets/d2080ed4-0a05-4b7a-8d0c-851753dcbea7

https://github.com/user-attachments/assets/26c5acae-eecf-4050-bf83-d8b8d6f2ed54

Details for Reviewers.

Need to re-type

opressor.dm

line 117 check if tile contains any structures, if one of checks is FALSE it will continue to next check.

line 162 check if structure is barricade then go to 164 and attach cade direction to "cade_facing" var.

line 165 check if cade_facing direction faces 180^ in opposite direction of casting, for example if you cast from west to east, if cade on east is facing west (towards you) it will then trigger line 166, where it sets "blocked = TRUE", preventing ability continuation.

line 167 check if cade_facing direction faces same direction you are casting at, for example if you cast from west to east and cade east is facing east (the direction you cast to) it will then trigger var "allow_one_more_step = TRUE", afterwards it will continue to line 168, where it will check if "allow_one_more_step" is TRUE, if it is, it will break code before it will reach end of turflist, thanks to that it will make hook appear at same tile as cade, but still get blocked (so you don't cast trough it).

Changelog

:cl: Venuska1117 balance: Abduction ability can now be casted at same tile with cade, flipped table and glass window panes, as long as it doesn't face praetorian ability casting direction. balance: Abduction ability can now be casted through small obstacles such as: window frames, small long crates, normal long crates, platform edges, disposal units (bins), hydro trays (plant trays), janitor cart, trash cans (hybrisia) line nexter (hybrisia). fix: Abduction ability can no longer be casted through multitile vehicles. fix: Abduction ability can no longer be casted through glass windows panes. /:cl

Jun 12 '25 12:06 Venuska1117

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

Jun 20 '25 00:06 cmss13-ci[bot]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

Jul 04 '25 00:07 cmss13-ci[bot]

Stale exempt until reviewed and tested

Jul 04 '25 22:07 Drulikar

I think there were edge case issues a few years ago with people being grabbed by warriors over cades at diagonal positions that neth fixed at some point. This might've been how it was fixed.

With how the grab works, I don't -think- it would be an issue for the praetorian, but you should double check and make sure that you can't get a successful diagonal grab on someone with a wall blocking the end of a cadeline.

Jul 24 '25 09:07 Wintermote

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sep 25 '25 11:09 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

Sep 26 '25 01:09 cm13-github

Test merge deployment history:

Test Merge Deployed @ 11/12/2025 17:24:10 +00:00:

Oppressor Praetorian: Fixes abduction ability interaction with objects.

About the pull request

Explain why it's good for the game

Testing Photographs and Procedure

Details for Reviewers.

Changelog

Test merge deployment history:

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance

Revision

Server Instance