cmss13 icon indicating copy to clipboard operation
cmss13 copied to clipboard

Guns can now drop bullet casings

Open Nihisohel opened this issue 6 months ago • 5 comments

About the pull request

Title, port of https://github.com/cmss13-devs/cmss13-pve/pull/925 which is a port of the PVE hardcore server. A port of a port of a port.

Although, I pretty much overhauled most of the systems, so its more of a ship of theseus dilemma

Explain why it's good for the game

Adds visual clutter for weapons that would properly need it. Good storytelling for survivors and the like.

Although, I did need to dig into its guts of the code and clean up some issues but otherwise the only problem would be the possible performance impact on the server, but most guns have a 15% chance to drop a casing anyhow

No, this won't affect caseless ammunition, obviously

Testing Photographs and Procedure

It works, would need a test merge for performance.

image

Changelog

:cl: add: Guns with the appropriate ammunition type and presentation now litter the ground with their spent cases and cartridges. spellcheck: Tweaks some misrepresented lore about XM43E1 casings. /:cl:

Nihisohel avatar May 31 '25 13:05 Nihisohel

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

cmss13-ci[bot] avatar Jun 13 '25 00:06 cmss13-ci[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Jun 13 '25 03:06 cm13-github

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

cmss13-ci[bot] avatar Jun 21 '25 00:06 cmss13-ci[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Oct 31 '25 03:10 cm13-github

Test merge deployment history:

Test Merge Deployed @ 11/04/2025 06:31:39 +00:00:
Server Instance

CM13 Live

Revision

Origin: c59da49226b4675feaa7ff0102ac612498e2dbc6 Pull Request: ab3584a236d3b545d61a615a558b8f27c853ff00 Server: a45398e6a9640697a3b90f84e9499cff844a57fc

Test Merge Updated @ 11/04/2025 11:59:51 +00:00:
Server Instance

CM13 Live

Revision

Origin: c59da49226b4675feaa7ff0102ac612498e2dbc6 Pull Request: d5627250b102d5cf8542b9170b7303551cc670b1 Server: bd9b652e6d7e116980e2d18bc57175a1da4dd1be

Test Merge Updated @ 11/04/2025 12:46:52 +00:00:
Server Instance

CM13 Live

Revision

Origin: c59da49226b4675feaa7ff0102ac612498e2dbc6 Pull Request: d5627250b102d5cf8542b9170b7303551cc670b1 Server: c41d95d9646d3b43ae4baa4eadaa73d645036c42

Test Merge Updated @ 11/04/2025 15:24:25 +00:00:
Server Instance

CM13 Live

Revision

Origin: c59da49226b4675feaa7ff0102ac612498e2dbc6 Pull Request: d5627250b102d5cf8542b9170b7303551cc670b1 Server: 231dc89082d90fe963401dfc6a59dcfbfae0f8cc

Test Merge Updated @ 11/04/2025 18:51:32 +00:00:
Server Instance

CM13 Live

Revision

Origin: 648b3818ea61f77595e18f43262e72ac71653124 Pull Request: d5627250b102d5cf8542b9170b7303551cc670b1 Server: 6a4b98350d657f6c6d3564094d629d1c853279f0

Test Merge Removed @ 11/04/2025 19:22:26 +00:00:
Server Instance

CM13 Live

cm13-github avatar Nov 04 '25 06:11 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Dec 12 '25 04:12 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Dec 13 '25 14:12 cm13-github