Queen permissions refactor to flags + forbid slashing fix
About the pull request
Revives #8792 but without lesser / hugger permissions.
Refactors queen hive permissions to use flags instead of boolean toggles.
Also makes slashing permissions do something. Only blocks direct harm-intent slashing and not any xeno abilities. Tail stabs and spitting will still harm marines even with slashing disabled.
Expanding slashing-disabled to include forbidding xeno abilities is beyond the scope of this PR.
Explain why it's good for the game
Queen says no attacking FOB? You better listen. Do it anyways? Now no more slashing for you.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the <details> tags.
Changelog
:cl: ihatethisengine, KornFlaks code: Refactored some of the toggles code fix: Fixed forbid slashing doing nothing /:cl:
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself
also I didn't test (waiting until code review complete) but you might want to test abilities too. I don't see much point to disable slashing if you can tailstab and use abilities to get around it. You might want to instead check slashing setting in can_not_harm proc instead.
BTW if you want to apply suggestions, please batch them:
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself
Will revive myself since this has gone through two attempts. Just reopened so I could apply my suggestions easily.