ChemMaster Presets.
About the pull request
- Added a preset system to the ChemMaster. This allows users to save, edit and apply configurations of pill bottle labels and colors, along with pill colors that they frequently use. The presets will persist between rounds and server restarts, being saved to the user creating them. Additionally, the preset system includes an optional quick access panel, allowing users to quickly apply a preset to selected pill bottles.
- Added the "Select All/Deselect All" button for the ChemMaster. This allows users to quickly select or deselect all bottles in the machine. The button only appears if two or more bottles are inserted into the ChemMaster.
- Fixed the bug which caused a delay in the UI response to selecting or deselecting pill bottles inside the ChemMaster.
Explain why it's good for the game
- The preset system improves quality of life for people who need to make lots of pills in a short span of time, especially before first drop. It does not affect the process of actually creating mixes, thus leaving the balance of chemistry intact. Additionally, the "Use preset name for bottle name" option allows users to quickly make the name of a pill bottle different from the label on its icon, which is useful for some custom medicine (e.g. a pill bottle labeled BM on the icon, but named "BM+QC - OD 30").
- Similarly to the presets, the "Select All/Deselect All" button improves QoL for doctors who do chemistry.
- Removing bugs is good for the game.
Testing Photographs and Procedure
Screenshots & Videos
The preset system flowchart, demonstrating the functionality.
https://github.com/user-attachments/assets/ff91b443-b5f0-4d18-a13b-4064e39276cf The delayed reaction of the UI.
https://github.com/user-attachments/assets/5887984d-64da-4175-b68c-d66de0757a46 The fixed instant UI update in reaction to user actions. Additionally, the function of Select/Deselect All
Changelog
:cl: BertStein add: Added a preset system for ChemMaster. ui: Added a "Select All/Deselect All" button for ChemMaster. fix: Fixed delay between selecting a pill bottle in ChemMaster and the UI responding. /:cl:
I never thought this day would come. Love this, except maybe it shouldn't be saved across rounds- that seems a little weird? It kinda breaks the "soft reset" that each round restarts as I understand it.
Plus, imo people should still have to learn chemistry- they shouldn't be able to copy paste from wiki once and never ever have to do it again. Copy pasting from the wiki several times, on the other hand, grants some familiarity until eventually you don't have to have the Chemistry CM13 wiki tab open on a separate monitor.
I never thought this day would come. Love this, except maybe it shouldn't be saved across rounds- that seems a little weird? It kinda breaks the "soft reset" that each round restarts as I understand it.
Plus, imo people should still have to learn chemistry- they shouldn't be able to copy paste from wiki once and never ever have to do it again. Copy pasting from the wiki several times, on the other hand, grants some familiarity until eventually you don't have to have the Chemistry CM13 wiki tab open on a separate monitor.
...What? This PR makes presets for the Names, on sprite short name, colours and pill shapes. It doesn't make chems for you.
As for the soft reset? I don't see how that applies at all. You wake up with stuff you came out of cryo with, instead of having to find them. You're not freshly cloned. You're doing a job on a ship, it makes sense you have time-savers for that job where you can.
people should still have to learn chemistry- they shouldn't be able to copy paste from wiki
As said previously, the preset system is only applicable to pill bottle color, pill bottle label and pill color in the ChemMaster. It does not affect the Chemical Dispenser or any other aspect of actually making a medical mix, aside from aesthetics.
I will edit the PR message to make it more clear that this does not affect the process of making chemical mixes.
Roger dodger, guess I skimmed it too fast! I saw presets and my mind jumped to Goon and such. I retract my previous comment.
I fucking kneel
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself
Stale exempt until tested
Appreciate the work you did on the backlog a lot, I've seen the amount of PRs the team had to go through. Thanks!