cmss13 icon indicating copy to clipboard operation
cmss13 copied to clipboard

Accessory attaching fixes and reorganization

Open Nihisohel opened this issue 7 months ago • 3 comments

About the pull request

Title, as well as some refactoring with restricted accessory attaching

Explain why it's good for the game

Rather than painstakingly adding a list of restricted accessory attachments to each goddamn armor type, accessory attachment limits are now tied to the accessory itself in conjunction to its category. This also means that there is now a limit to the number of patches you can apply to your uniform, no more infinity stacking of patches.

Fixes ties and patches being unable to be attached by giving them their own category. Recategorizes the uniform storage accessories from ACCESSORY_SLOT_UTILITY to ACCESSORY_SLOT_STORAGE Stethoscopes are now categorized as ACCESSORY_SLOT_UTILITY for better readability

Cleans up the valid_accessory list from every instance that it's on, no more redundant listings when a goddamn parent actually has a list of all you need. As a result, accessory attaching is somewhat expanded, and you can now attach patches onto armors although it may look ugly padless and sleeveless.

#9244 is still good to keep up, but ideally future implementations of accessories should not at all make use of ACCESSORY_SLOT_DEFAULT and should be in its own category or within an existing one.

Testing Photographs and Procedure

image image

Changelog

:cl: add: You can now attach patches on armor; this might look ugly if you are sleeveless and padless, however. add: Nearly every exosuit clothing can now hold accessories. fix: Accessories now have a limit to them, typically only 1 but some items can go up to 4. code: Cleans up the valid accessory lists. refactor: Defuncts restricted_accessory_slots on clothings for a more intuitive per accessory slot limit dependent on accessory category. /:cl:

Nihisohel avatar May 08 '25 08:05 Nihisohel

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar May 13 '25 00:05 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar May 13 '25 04:05 cm13-github

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

cmss13-ci[bot] avatar May 21 '25 00:05 cmss13-ci[bot]