Set all groundside xenos to forsaken after hijack crash

[benrobey]

About the pull request

• ~~Leverages the code in check_ground_humans proc that already loops through all groundside xenos to force them to forsaken hive~~
• Add new HIJACK_OBJECTIVES_SHIP_INBOUND that is set when the shuttle is called by the queen
• Use HIJACK_OBJECTIVES_SHIP_INBOUND to control groundside larva spawning as forsaken
• fixes: #9008 https://github.com/cmss13-devs/cmss13/issues/9008

Explain why it's good for the game

It doesn't make sense that we are setting all groundside turfs to forsaken and "hibernating" stranded xenos, yet if a xeno bursts post hijack it's set to the normal hive.

Changelog

:cl: fix: fixed groundside xenos not getting correctly set to forsaken hive after hijack /:cl:

[efzapa]

change your PR desc to fixes #9008 so it actually auto-closes upon merge

[benrobey]

change your PR desc to fixes #9008 so it actually auto-closes upon merge

Done now, thanks

[benrobey]

This somewhat seems to be doing it too late? If groundside larva burst they should turn into forsaken as soon as they spawn, not when the dropship crashes

I agree that this is a somewhat hacky fix due to me being new to the codebase and dm, it does work, although it would be more ideal if the embryos were set to the forsaken hive when they spawn as you say. I'll make some changes and rerequest review.

[Git-Nivrak]

This somewhat seems to be doing it too late? If groundside larva burst they should turn into forsaken as soon as they spawn, not when the dropship crashes

I agree that this is a somewhat hacky fix due to me being new to the codebase and dm, it does work, although it would be more ideal if the embryos were set to the forsaken hive when they spawn as you say. I'll make some changes and rerequest review.

All good, If you need help feel free to ask on discord

[cmss13-ci[bot]]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

[benrobey]

This somewhat seems to be doing it too late? If groundside larva burst they should turn into forsaken as soon as they spawn, not when the dropship crashes

I agree that this is a somewhat hacky fix due to me being new to the codebase and dm, it does work, although it would be more ideal if the embryos were set to the forsaken hive when they spawn as you say. I'll make some changes and rerequest review.

All good, If you need help feel free to ask on discord

I've rethought how I was doing this and now this code essentially does what you suggested and sets the larva to forsaken upon spawning.

[cmss13-ci[bot]]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

[benrobey]

Sorry this has taken me so long to circle back to, been working on my other PR. Will test this week and update

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[benrobey]

This still doesn't cover bursts, only larva spawned from core (which despawns anyway after xenos hijack)

I did test it though for bursts and it did seem to work (my procedure was to nest infected humans, then hijack, and then ensure that forsaken larva were spawned), can you point me towards the proc that is called for bursting if you know what it is? Otherwise I can revisit this and double check that it's covering bursts.

[benrobey]

This still doesn't cover bursts, only larva spawned from core (which despawns anyway after xenos hijack)

I did test it though for bursts and it did seem to work (my procedure was to nest infected humans, then hijack, and then ensure that forsaken larva were spawned), can you point me towards the proc that is called for bursting if you know what it is? Otherwise I can revisit this and double check that it's covering bursts.

Revisited this again, added some lines in the add_xeno proc to achieve the intended behaviour

[benrobey]

Sorry for the spam and wrong labels being added back here, messed up the history with a bad rebase causing the bot to add these irrelevant ones.

[Nanu308]

Removed mapping etc. tags as i see no related changes to those